From: Joe Perches <joe@perches.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux@rasmusvillemoes.dk, andriy.shevchenko@linux.intel.com,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] vsprintf: automatic parameters for %pIS via 'a'
Date: Wed, 03 Feb 2016 15:37:12 -0800 [thread overview]
Message-ID: <1454542632.7291.144.camel@perches.com> (raw)
In-Reply-To: <1454542185-1147-1-git-send-email-Jason@zx2c4.com>
On Thu, 2016-02-04 at 00:29 +0100, Jason A. Donenfeld wrote:
> This patch adds a variable 'a' which indicates that the 'p',
> 'f', and 's' options should be toggled on or off depending on
> whether or not those parameters are actually valid inside the
> passed sockaddr.
trivia:
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -1225,9 +1234,15 @@ char *ip4_addr_string_sa(char *buf, char *end, const struct sockaddr_in *sa,
[]
> + if (have_a)
> + have_p = sa->sin_port != 0;
> +
different style than the v6 tests
next prev parent reply other threads:[~2016-02-03 23:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 10:41 [PATCH] vsprintf: do not append unset Scope ID to IPv6 Jason A. Donenfeld
2016-02-03 12:13 ` [PATCH] vsprintf: flowinfo in IPv6 is optional too Jason A. Donenfeld
2016-02-03 17:56 ` IRe: " Joe Perches
2016-02-03 21:09 ` Jason A. Donenfeld
2016-02-03 21:13 ` Andy Shevchenko
2016-02-03 21:13 ` IRe: " Daniel Borkmann
2016-02-03 21:15 ` Jason A. Donenfeld
2016-02-03 21:07 ` [PATCH] vsprintf: do not append unset Scope ID to IPv6 Daniel Borkmann
2016-02-03 21:14 ` Jason A. Donenfeld
2016-02-03 21:47 ` Joe Perches
2016-02-03 22:09 ` Daniel Borkmann
2016-02-03 22:42 ` Jason A. Donenfeld
2016-02-03 22:53 ` [PATCH] vsprintf: automatic parameters for %pIS via 'a' Jason A. Donenfeld
2016-02-03 23:05 ` Joe Perches
2016-02-03 23:25 ` Jason A. Donenfeld
2016-02-03 23:29 ` [PATCH v2] " Jason A. Donenfeld
2016-02-03 23:37 ` Joe Perches [this message]
2016-02-04 0:59 ` [PATCH v3] " Jason A. Donenfeld
2016-02-05 0:06 ` [PATCH v2] " Rasmus Villemoes
2016-02-05 13:06 ` Jason A. Donenfeld
2016-02-05 13:37 ` [PATCH] " Jason A. Donenfeld
2016-02-05 13:39 ` [PATCH v4] " Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454542632.7291.144.camel@perches.com \
--to=joe@perches.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome