From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>,
<linux-kernel@vger.kernel.org>,
James Hogan <james.hogan@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] MIPS: Stop using dla in 32 bit kernels
Date: Thu, 4 Feb 2016 14:31:57 +0000 [thread overview]
Message-ID: <1454596317-5042-1-git-send-email-paul.burton@imgtec.com> (raw)
The instruction_hazard macro made use of the dla pseudo-instruction even
for 32 bit kernels. Although it surrounded that use with ".set mips64rX"
that isn't sufficient to avoid warnings when built with -mabi=32, as
CONFIG_32BIT=y kernels are:
CC arch/mips/mm/c-r4k.o
{standard input}: Assembler messages:
{standard input}:4105: Warning: dla used to load 32-bit register;
recommend using la instead
{standard input}:4129: Warning: dla used to load 32-bit register;
recommend using la instead
Avoid this by instead making use of the PTR_LA macro which defines the
appropriate variant of the "la" instruction to use.
Tested with Codescape GNU Tools 2015.06-05 for MIPS IMG Linux, which
includes binutils 2.24.90 & gcc 4.9.2.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---
arch/mips/include/asm/hazards.h | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/arch/mips/include/asm/hazards.h b/arch/mips/include/asm/hazards.h
index 7b99efd..ffe2aaa 100644
--- a/arch/mips/include/asm/hazards.h
+++ b/arch/mips/include/asm/hazards.h
@@ -11,6 +11,7 @@
#define _ASM_HAZARDS_H
#include <linux/stringify.h>
+#include <asm/asm.h>
#include <asm/compiler.h>
#define ___ssnop \
@@ -54,22 +55,16 @@
/*
* gcc has a tradition of misscompiling the previous construct using the
- * address of a label as argument to inline assembler. Gas otoh has the
- * annoying difference between la and dla which are only usable for 32-bit
- * rsp. 64-bit code, so can't be used without conditional compilation.
- * The alterantive is switching the assembler to 64-bit code which happens
- * to work right even for 32-bit code ...
+ * address of a label as argument to inline assembler.
*/
#define instruction_hazard() \
do { \
unsigned long tmp; \
\
__asm__ __volatile__( \
- " .set "MIPS_ISA_LEVEL" \n" \
- " dla %0, 1f \n" \
- " jr.hb %0 \n" \
- " .set mips0 \n" \
- "1: \n" \
+ __stringify(PTR_LA) " %0, 1f\n\t" \
+ "jr.hb %0\n\t" \
+ "1:" \
: "=r" (tmp)); \
} while (0)
--
2.7.0
next reply other threads:[~2016-02-04 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 14:31 Paul Burton [this message]
2016-02-04 15:18 ` Ralf Baechle
2016-02-04 15:49 ` Paul Burton
2016-02-04 16:15 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454596317-5042-1-git-send-email-paul.burton@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®