From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758181AbcBDXyl (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 18:54:41 -0500
Received: from e23smtp01.au.ibm.com ([202.81.31.143]:33371 "EHLO
	e23smtp01.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758128AbcBDXyh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 18:54:37 -0500
X-IBM-Helo: d23dlp03.au.ibm.com
X-IBM-MailFrom: zohar@linux.vnet.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-modules@vger.kernel.org;linux-security-module@vger.kernel.org
Message-ID: <1454630013.2648.12.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH v3.1] firmware: clean up filesystem load exit path
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: Kees Cook <keescook@chromium.org>, "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Josh Boyer <jwboyer@fedoraproject.org>,
        David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org,
        David Woodhouse <dwmw2@infradead.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        Eric Biederman <ebiederm@xmission.com>,
        Rusty Russell <rusty@rustcorp.com.au>,
        linux-security-module@vger.kernel.org, kexec@lists.infradead.org,
        linux-modules@vger.kernel.org
Date: Thu, 04 Feb 2016 18:53:33 -0500
In-Reply-To: <20160204220122.GL12481@wotan.suse.de>
References: <20160204211501.GA14755@www.outflux.net>
	 <20160204220122.GL12481@wotan.suse.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16020423-1618-0000-0000-000026F4B42E
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2016-02-04 at 23:01 +0100, Luis R. Rodriguez wrote:
> On Thu, Feb 04, 2016 at 01:15:02PM -0800, Kees Cook wrote:
> > This makes the error and success paths more readable while trying to
> > load firmware from the filesystem.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > Cc: Josh Boyer <jwboyer@fedoraproject.org>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> > Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> 
> Thanks,
> 
> Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
> 
> > ---
> > Suggested as an alternative to "[PATCH v3 06/22] firmware: fold successful fw read early"
> 
> Mimi, feel free to pick up as a replacement in your series.

Ok, thanks!

Mimi