From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbcBEPHZ (ORCPT ); Fri, 5 Feb 2016 10:07:25 -0500 Received: from shell.v3.sk ([92.60.52.57]:53824 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbcBEPHX convert rfc822-to-8bit (ORCPT ); Fri, 5 Feb 2016 10:07:23 -0500 Message-ID: <1454684832.2779.10.camel@v3.sk> Subject: Re: [PATCH 3/3] bonding: make device count build-time configurable From: Lubomir Rintel To: =?ISO-8859-1?Q?Bj=F8rn?= Mork , David Miller Cc: jay.vosburgh@canonical.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vfalico@gmail.com, gospo@cumulusnetworks.com Date: Fri, 05 Feb 2016 16:07:12 +0100 In-Reply-To: <87bn8qv5m4.fsf@nemi.mork.no> References: <1452599916-27511-1-git-send-email-lkundrak@v3.sk> <8166.1452616452@famine> <1452619189.18559.83.camel@v3.sk> <20160112.154914.397367508465928770.davem@davemloft.net> <87bn8qv5m4.fsf@nemi.mork.no> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjørn, On Tue, 2016-01-12 at 22:40 +0100, Bjørn Mork wrote: > David Miller writes: > > From: Lubomir Rintel > > Date: Tue, 12 Jan 2016 18:19:49 +0100 > > > > > It's still an improvement to let the distributions decide if > > > they're > > > keeping "ip link add" broken or possibly affecting the scripts. > > > > That it is "broken" is your opinion. > > > > Document the behavior.  It is not broken if the user is told to be > > mindful of what devices are created by default. > > > > There is way too much downside to changing this. > > Besides, distributions or admins can already change that behaviour if > they consider it "broken", using the existing module parameter: > >  # echo "options bonding max_bonds=0" >/etc/modprobe.d/bonding.conf >  # rmmod bonding >  # ip link add bond0 type bond >  (no error here) > > This method should be well known and understood by most users, > contrary > to some odd CONFIG_ build time setting. Yes, that's an alternative solution. We may end up shipping such configuration file, though it's not really clear what package should ship it (probably systemd?). I'd still prefer a kernel build-time option. It's more likely for distributions to do the decision they prefer when running make oldconfig. I'm assuming most distros would like to drop the legacy behavior; at this point noone probably relies on it anyway, given NetworkManager works around this by manually loading the module with the maxbonds=0 manually. Also, there's prior art to addressing this in kernel; the block loopback. > Bjørn Regards, Lubo