mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Chunyan Zhang <zhang.chunyan@linaro.org>,
	laurent.fert@intel.com, yann.fouassier@intel.com,
	linux-kernel@vger.kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [QUEUED v0 16/19] stm class: Support devices with multiple instances
Date: Fri,  5 Feb 2016 18:35:25 +0200	[thread overview]
Message-ID: <1454690128-21994-17-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1454690128-21994-1-git-send-email-alexander.shishkin@linux.intel.com>

By convention, the name of the stm policy directory in configfs consists of
the device name to which it applies and the actual policy name, separated
by a dot. Now, some devices already have dots in their names that separate
name of the actual device from its instance identifier. Such devices will
result in two (or more, who can tell) dots in the policy directory name.

Existing policy code, however, will treat the first dot as the one that
separates device name from policy name, therefore failing the above case.

This patch makes the last dot in the directory name be the separator, thus
prohibiting dots from being used in policy names.

Suggested-by: Chunyan Zhang <zhang.chunyan@linaro.org>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/policy.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c
index 94d3abfb73..1db189657b 100644
--- a/drivers/hwtracing/stm/policy.c
+++ b/drivers/hwtracing/stm/policy.c
@@ -332,10 +332,11 @@ stp_policies_make(struct config_group *group, const char *name)
 
 	/*
 	 * node must look like <device_name>.<policy_name>, where
-	 * <device_name> is the name of an existing stm device and
-	 * <policy_name> is an arbitrary string
+	 * <device_name> is the name of an existing stm device; may
+	 *               contain dots;
+	 * <policy_name> is an arbitrary string; may not contain dots
 	 */
-	p = strchr(devname, '.');
+	p = strrchr(devname, '.');
 	if (!p) {
 		kfree(devname);
 		return ERR_PTR(-EINVAL);
-- 
2.7.0

  parent reply	other threads:[~2016-02-05 16:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-05 16:35 [QUEUED v0 00/19] stm class/intel_th: Patches in my queue Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 01/19] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 02/19] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 03/19] stm class: Select CONFIG_SRCU Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 04/19] stm class: Fix locking in unbinding policy path Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 05/19] stm class: Fix link list locking Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 06/19] stm class: Fix an off-by-one in master array allocation Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 07/19] stm class: Prevent user-controllable allocations Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 08/19] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 09/19] intel_th: pci: Add Broxton " Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 10/19] stm class: Use a signed return type for stm_find_master_chan Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 11/19] intel_th: Depend on HAS_IOMEM Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 12/19] intel_th: gth: Remove commented-out code Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 13/19] intel_th: Update scratchpad bits according to enabled output activity Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 14/19] stm class: Use driver's packet callback's return value Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 15/19] intel_th: sth: Sanitize packet callback's return values Alexander Shishkin
2016-02-05 16:35 ` Alexander Shishkin [this message]
2016-02-05 16:35 ` [QUEUED v0 17/19] stm class: dummy_stm: Create multiple devices Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 18/19] intel_th: Set root device's drvdata early Alexander Shishkin
2016-02-05 16:35 ` [QUEUED v0 19/19] intel_th: Use real device index in the node names Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454690128-21994-17-git-send-email-alexander.shishkin@linux.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=laurent.fert@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=yann.fouassier@intel.com \
    --cc=zhang.chunyan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®