From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH 3/8] [media] tvp5150: put endpoint node on error
Date: Fri, 5 Feb 2016 16:09:53 -0300 [thread overview]
Message-ID: <1454699398-8581-4-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1454699398-8581-1-git-send-email-javier@osg.samsung.com>
If the parallel mbus configuration is not correct, the endpoint
device node isn't currently put again in the error path. Fix it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/tvp5150.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 19b52736b24e..c7eeb59a999b 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1268,8 +1268,10 @@ static int tvp5150_parse_dt(struct tvp5150 *decoder, struct device_node *np)
if (bus_cfg.bus_type == V4L2_MBUS_PARALLEL &&
!(flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH &&
flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH &&
- flags & V4L2_MBUS_FIELD_EVEN_LOW))
- return -EINVAL;
+ flags & V4L2_MBUS_FIELD_EVEN_LOW)) {
+ ret = -EINVAL;
+ goto err;
+ }
decoder->mbus_type = bus_cfg.bus_type;
--
2.5.0
next prev parent reply other threads:[~2016-02-05 19:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 19:09 [PATCH 0/8] [media] tvp5150: add HW input connectors support Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 1/8] [media] v4l2-subdev: add registered_async subdev core operation Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 2/8] [media] v4l2-async: call registered_async after subdev registration Javier Martinez Canillas
2016-08-11 11:10 ` Sakari Ailus
2016-08-11 11:18 ` Sakari Ailus
2016-08-11 16:14 ` Javier Martinez Canillas
2016-08-11 19:28 ` Sakari Ailus
2016-02-05 19:09 ` Javier Martinez Canillas [this message]
2016-02-05 19:09 ` [PATCH 4/8] [media] tvp5150: store dev id and rom version Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 5/8] [media] tvp5150: add internal signal generator to HW input list Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 6/8] [media] tvp5150: move input definition header to dt-bindings Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 7/8] [media] tvp5150: document input connectors DT bindings Javier Martinez Canillas
2016-02-08 18:23 ` Javier Martinez Canillas
2016-02-05 19:09 ` [PATCH 8/8] [media] tvp5150: add HW input connectors support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454699398-8581-4-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®