From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbcBFOt2 (ORCPT ); Sat, 6 Feb 2016 09:49:28 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10960 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752610AbcBFOtZ (ORCPT ); Sat, 6 Feb 2016 09:49:25 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Sat, 06 Feb 2016 06:49:58 -0800 From: Laxman Dewangan To: , , , , , , CC: , , , Laxman Dewangan Subject: [PATCH V4 5/6] mfd: max77686: do not set i2c client data for rtc i2c client Date: Sat, 6 Feb 2016 20:07:26 +0530 Message-ID: <1454769447-785-6-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is different RTC I2C address for RTC block in MAX77686. Driver is creating dummy i2c client for this address to access the register of this IP block. As there is no call to i2c_get_clientdata() for rtc_i2c client, there is no need to store pointer and hence removing the call to set client data for rtc i2c client. Suggested-by: Krzysztof Kozlowski Signed-off-by: Laxman Dewangan CC: Krzysztof Kozlowski CC: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- This is new in this series based on review comment from V1. Changes from V2: - Rephrase description. - Added reviewed by. Changes from V3: - None, become 5th on series. drivers/mfd/max77686.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c index d959ebb..bda6fd7 100644 --- a/drivers/mfd/max77686.c +++ b/drivers/mfd/max77686.c @@ -277,7 +277,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, "Failed to allocate I2C device for RTC\n"); return -ENODEV; } - i2c_set_clientdata(max77686->rtc, max77686); max77686->rtc_regmap = devm_regmap_init_i2c(max77686->rtc, -- 2.1.4