From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220AbcBGQEF (ORCPT ); Sun, 7 Feb 2016 11:04:05 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:47486 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbcBGQED (ORCPT ); Sun, 7 Feb 2016 11:04:03 -0500 Message-ID: <1454861040.2329.4.camel@HansenPartnership.com> Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional From: James Bottomley To: Christoph Hellwig Cc: "linux-nvme@lists.infradead.org" , linux-block@vger.kernel.org, linux-scsi , linux-kernel , Jens Axboe Date: Sun, 07 Feb 2016 08:04:00 -0800 In-Reply-To: <20160207092241.GA15331@lst.de> References: <1454783624.2809.6.camel@HansenPartnership.com> <20160207092241.GA15331@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-02-07 at 10:22 +0100, Christoph Hellwig wrote: > Keith said it should be on by default, and I promised him to change > it once we run into problems, which I guess this counts as. > > But just curious: what distro are you using? Upstream systemd > explicitly rejected using scsi_id for NVMe here: > > https://github.com/systemd/systemd/issues/1453 > > and all my test systems don't do this either. This was SUSE (in my case, openSUSE Leap). I just checked the source package; they patch the by-id rules back in for NVME: # PATCH-FIX-SUSE 1101-rules-persistent-device-names-for-NVMe-devices.patch (bsc#944132) Patch1101: 1101-rules-persistent-device-names-for-NVMe-devices.patch The bugzilla is giving access denied for bug id 944132, so it's likely some proprietary vendor problem. The patch has no preamble, so it's hard to tell what they were thinking. James