From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ARM: descend into arch/arm/boot only once to generate boot images
Date: Mon, 8 Feb 2016 14:04:59 +0900 [thread overview]
Message-ID: <1454907899-32101-2-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1454907899-32101-1-git-send-email-yamada.masahiro@socionext.com>
Commit 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not
generate invalid images") fixed bad images generation in the parallel
building, but it is not efficient to descend into arch/arm/boot over
and over again. It is also clumsy to display the same log message
"Kernel: arch/arm/boot/Image is ready" a couple of times.
$ make ARCH=arm UIMAGE_LOADADDR=0x80208000 all uImage
[snip]
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/zImage is ready
Building modules, stage 2.
MODPOST 279 modules
Kernel: arch/arm/boot/Image is ready
Kernel: arch/arm/boot/zImage is ready
UIMAGE arch/arm/boot/uImage
Image Name: Linux-4.5.0-rc3
Created: Mon Feb 8 13:22:53 2016
Image Type: ARM Linux Kernel Image (uncompressed)
Data Size: 6768768 Bytes = 6610.12 kB = 6.46 MB
Load Address: 80208000
Entry Point: 80208000
Image arch/arm/boot/uImage is ready
This commit allows arch/arm/boot/Makefile to build boot images at once
instead of generating them one by one. Of course, it works correctly
also in parallel building.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/Makefile | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index d6d453f..6db669e 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -315,13 +315,17 @@ archprepare:
BOOT_TARGETS = zImage Image xipImage bootpImage uImage
INSTALL_TARGETS = zinstall uinstall install
-PHONY += $(BOOT_TARGETS) $(INSTALL_TARGETS)
+PHONY += $(BOOT_TARGETS) $(INSTALL_TARGETS) __build_images
-bootpImage uImage: zImage
-zImage: Image
+$(BOOT_TARGETS): __build_images
+ @:
-$(BOOT_TARGETS): vmlinux
- $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
+__build_images: vmlinux
+ $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) \
+ $(addprefix $(boot)/,
+ $(sort $(filter $(BOOT_TARGETS),$(MAKECMDGOALS)) \
+ $(if $(filter all,$(MAKECMDGOALS)), $(KBUILD_IMAGE)) \
+ $(if $(MAKECMDGOALS),,$(KBUILD_IMAGE))))
$(INSTALL_TARGETS):
$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
--
1.9.1
next prev parent reply other threads:[~2016-02-08 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 5:04 [PATCH 1/2] ARM: remove bzImage target Masahiro Yamada
2016-02-08 5:04 ` Masahiro Yamada [this message]
2016-02-08 12:18 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454907899-32101-2-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®