From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbcBHJeI (ORCPT ); Mon, 8 Feb 2016 04:34:08 -0500 Received: from ozlabs.org ([103.22.144.67]:51761 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcBHJeG (ORCPT ); Mon, 8 Feb 2016 04:34:06 -0500 Message-ID: <1454924036.30809.1.camel@ellerman.id.au> Subject: Re: + kernel-locking-lockdepc-make-lockdep-initialize-itself-on-demand.patch added to -mm tree From: Michael Ellerman To: Andrey Ryabinin , Andrew Morton , Ingo Molnar , krinkin.m.u@gmail.com, mingo@elte.hu, peterz@infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner Date: Mon, 08 Feb 2016 20:33:56 +1100 In-Reply-To: <56B34E87.1030604@virtuozzo.com> References: <56b11d2d.vVw1kB2la7Y+70xF%akpm@linux-foundation.org> <20160203074430.GA32652@gmail.com> <20160203085111.fc3f2631.akpm@linux-foundation.org> <20160203124009.0325b983b74fa15082f13f4d@linux-foundation.org> <20160203134403.aa944de2a3863b9a4beccf63@linux-foundation.org> <56B34E87.1030604@virtuozzo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-04 at 16:13 +0300, Andrey Ryabinin wrote: > On 02/04/2016 12:44 AM, Andrew Morton wrote: > > Probably lockdep_init() and lockdep_initialized can be done away with now. > > Yup, it probably should be folded into your patch, or we could hold this off for 4.6. > > From: Andrey Ryabinin > > Subject: kernel/lockdep: eliminate lockdep_init() > > Lockdep is initialized at compile time now. Get rid of lockdep_init(). > > Signed-off-by: Andrey Ryabinin > diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c > index ad8c9db..d544fa3 100644 > --- a/arch/powerpc/kernel/setup_32.c > +++ b/arch/powerpc/kernel/setup_32.c > @@ -114,8 +114,6 @@ extern unsigned int memset_nocache_branch; /* Insn to be replaced by NOP */ > > notrace void __init machine_init(u64 dt_ptr) > { > - lockdep_init(); > - > /* Enable early debugging if any specified (see udbg.h) */ > udbg_early_init(); > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 5c03a6a..f98be83 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -255,9 +255,6 @@ void __init early_setup(unsigned long dt_ptr) > setup_paca(&boot_paca); > fixup_boot_paca(); > > - /* Initialize lockdep early or else spinlocks will blow */ > - lockdep_init(); > - > /* -------- printk is now safe to use ------- */ > > /* Enable early debugging if any specified (see udbg.h) */ Yes please. That has been a royal pain over the years and is still fragile, very happy to see the back of it. Acked-by: Michael Ellerman (powerpc) cheers