From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbcBHMxv (ORCPT ); Mon, 8 Feb 2016 07:53:51 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51438 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799AbcBHMxt (ORCPT ); Mon, 8 Feb 2016 07:53:49 -0500 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Eddie Huang , Matthias Brugger , Sascha Hauer , Paul Gortmaker , Matt Redfearn , Paul Burton , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] serial: 8250: fix building Ingenic with SERIAL_8250=m Date: Mon, 8 Feb 2016 13:51:43 +0100 Message-Id: <1454935947-2743255-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454935947-2743255-1-git-send-email-arnd@arndb.de> References: <1454935947-2743255-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:OsiPyREPSJdAALh6DuBHE7O2bt6fT7F4muqYcvrbbMqOBUXU+PR s5DcBXZuMYB32JkhtY+3K28Lu4vVebYm2S2Efev3VzXI+lFAMT0b8v/fPazI9dpLXR8Jwp4 M07NIxGcD14Z6sDVeIP5pc3+r6FnsFqbVG6wwaCM2HCVAb+Sd/Ah4PUsT2UjNEdP9whlV0z fIN8KGH+BQ8m9M9MLDDNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wr3rFAIYlpQ=:X3vqhhk5TtzMvbusZad2Ln midNMU2R1ndiRQ57EI5c60UVDUS4u+tgL0AAIqiaMHzim2MZk+RWcAUFNZgkqrK4kEpvJpCGk vYGjLglU2b7GxXdFZFEBhyLCVUj8xhumJ8kBQishV5T9CmVhuuLRtJVrE/b2mMowFUHV3V1Pp pCPmpwcfXDqLPaFcI0z3/WcBeNarMJjcEVxdsIhR6iiasDfg3RnjzpBbzmdHje+g5pLBeEZHg t9K2HNNgcNFPQAun28TYK/SNkD9xF1L3jjKpiJg3HEvPukjiZd/NOFabcTM9ZSspxJBNzZXNy jGLsLeJfe2Sjz6bm9q7jxMBrxdNiXnw94dAvGT2/lQIzkz4fAZknORBwmgG/NXIb05/Pf7Fic qJ72bsDiRBEju4d6DD9+Okx0MwOnJEtONjkIoOBUVVBanYV52V4k9yoPRUPOYs+i4nOlpJm0J 3rRRHuEEJRwMNnvZhpc1/PKctGJUHdoBeVdn52TcazpFgJqfrNuPEYUbV7x4/SfGSUZp1r399 GhWyMSpdGkV20K4OCZo5cTM/c0VYjOyoKqJvBgPUGmTEZJ90WAob3u/qM6X9A2Q9AgU7/jtEO gr96SBHB5lLudGcmJazpMbXUUiq4d9qMdsvtHX/FQFBkGSWoHImESmWvSCxdqjWXO2Q3I4q4y +Yc1HJTcxkuWe56zNadtdrq7Bm4K60r0yi98SOYEXOtJx/O4mjGIrpUSbTU+zPooPaYo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Ingenic 8250 driver has a 'bool' Kconfig symbol, but that breaks when SERIAL_8250 is a loadable module: drivers/tty/built-in.o: In function `ingenic_uart_probe': 8250_ingenic.c:(.text+0x1c1a0): undefined reference to `serial8250_register_8250_port' This changes the symbol to a 'tristate', plus a dependency on SERIAL_8250, which makes it work again. Unlike the other soc-specific backends, this one has no dependency on an architecture or a platform. I'm adding a dependency on MIPS || COMPILE_TEST as well here, to avoid showing the driver on architectures that are not interested in it. Signed-off-by: Arnd Bergmann --- drivers/tty/serial/8250/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 6ae0fae4f796..13c63b14179f 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -384,8 +384,8 @@ config SERIAL_8250_UNIPHIER serial ports, say Y to this option. If unsure, say N. config SERIAL_8250_INGENIC - bool "Support for Ingenic SoC serial ports" - depends on OF_FLATTREE + tristate "Support for Ingenic SoC serial ports" + depends on SERIAL_8250 && OF_FLATTREE && (MIPS || COMPILE_TEST) select LIBFDT help If you have a system using an Ingenic SoC and wish to make use of -- 2.7.0