From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438AbcBHRZr (ORCPT ); Mon, 8 Feb 2016 12:25:47 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36171 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcBHRZn (ORCPT ); Mon, 8 Feb 2016 12:25:43 -0500 From: Sudip Mukherjee To: Greg Kroah-Hartman , Christian Gromm Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH v2] staging: most: return error value Date: Mon, 8 Feb 2016 22:55:34 +0530 Message-Id: <1454952334-28939-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On error we were returning retval, but retval is not having the error value. We will get the error value using PTR_ERR. Signed-off-by: Sudip Mukherjee --- v2: sent after rebasing drivers/staging/most/aim-cdev/cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c index 3a2dbf1..de4f76a 100644 --- a/drivers/staging/most/aim-cdev/cdev.c +++ b/drivers/staging/most/aim-cdev/cdev.c @@ -470,8 +470,8 @@ static int aim_probe(struct most_interface *iface, int channel_id, NULL, "%s", name); - retval = IS_ERR(c->dev); - if (retval) { + if (IS_ERR(c->dev)) { + retval = PTR_ERR(c->dev); pr_info("failed to create new device node %s\n", name); goto error_create_device; } -- 1.9.1