mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Henderson <joshua.henderson@microchip.com>
To: <linux-kernel@vger.kernel.org>
Cc: Cristian Birsan <cristian.birsan@microchip.com>,
	Joshua Henderson <joshua.henderson@microchip.com>,
	Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>
Subject: [PATCH v2 1/2] usb: musb: Fix DMA for host mode
Date: Mon, 8 Feb 2016 15:15:29 -0700	[thread overview]
Message-ID: <1454969730-18480-1-git-send-email-joshua.henderson@microchip.com> (raw)

From: Cristian Birsan <cristian.birsan@microchip.com>

Commit ac33cdb16681 ("usb: musb: Remove ifdefs for musb_host_rx in
musb_host.c part5") introduces a problem setting DMA host mode.

This commit fixes the done condition that advances the musb schedule.
Without this patch the the msub_advance_schedule() is called immediately
after receiving an endpoint rx interrupt without waiting for the dma
transfer to complete. As a consequence when the dma complete interrupt
arrives the in_qh member of hw_ep is already null an the musb_host_rx()
exits on !urb error case.

Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
Changes since v1:
	- Don't add unecessary new variable. Just correct done.
---
 drivers/usb/musb/musb_host.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 795a45b..6bef86f 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -2006,9 +2006,15 @@ void musb_host_rx(struct musb *musb, u8 epnum)
 			done = musb_rx_dma_in_inventra_cppi41(c, hw_ep, qh,
 							      urb, xfer_len,
 							      iso_err);
-			if (done)
+			if (done) {
+				/* Don't call msub_advance_schedule()
+				 * immediately after receiving an endpoint RX
+				 * interrupt without waiting for the DMA
+				 * transfer to complete.
+				 */
+				done = false;
 				goto finish;
-			else
+			} else
 				dev_err(musb->controller, "error: rx_dma failed\n");
 		}
 
-- 
1.7.9.5

             reply	other threads:[~2016-02-08 22:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 22:15 Joshua Henderson [this message]
2016-02-08 22:15 ` [PATCH v2 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson
2016-02-09 11:14   ` Sergei Shtylyov
2016-02-09 11:06 ` [PATCH v2 1/2] usb: musb: Fix DMA for host mode Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454969730-18480-1-git-send-email-joshua.henderson@microchip.com \
    --to=joshua.henderson@microchip.com \
    --cc=balbi@ti.com \
    --cc=cristian.birsan@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®