From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757014AbcBHW5t (ORCPT ); Mon, 8 Feb 2016 17:57:49 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34738 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755059AbcBHW5r (ORCPT ); Mon, 8 Feb 2016 17:57:47 -0500 Message-ID: <1454972260.7627.368.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net v3 2/4] net: add rx_nohandler stat counter From: Eric Dumazet To: Stephen Hemminger Cc: Jarod Wilson , David Miller , linux-kernel@vger.kernel.org, edumazet@google.com, jiri@mellanox.com, daniel@iogearbox.net, tom@herbertland.com, j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org Date: Mon, 08 Feb 2016 14:57:40 -0800 In-Reply-To: <20160208113821.0ba26eb0@xeon-e3> References: <1454370667-2328-1-git-send-email-jarod@redhat.com> <1454370667-2328-3-git-send-email-jarod@redhat.com> <20160207113732.25a88cc4@xeon-e3> <20160207.144648.750890874940574761.davem@davemloft.net> <1454876368.7627.350.camel@edumazet-glaptop2.roam.corp.google.com> <20160208183254.GB4566@redhat.com> <20160208113821.0ba26eb0@xeon-e3> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-08 at 11:38 -0800, Stephen Hemminger wrote: > The iproute2 command can be fixed, but adding dependency on size of response > gets gross fast. Imagine when 4 more fields get added, this doesn't scale well. Really ? I see no problem at all doing the proper tests. > > Also, the definition of userspace ABI is that structures can't change. > There are many other utilities that are not visible that may get broken. > Traditionally Linux has guaranteed that programs will continue to work > no matter how they were coded. Stephen, we have been doing that for years. Whole point of TLV is that it allows us to add new fields at the end of the structures. Yes, some buggy programs might need a fix. Look at iproute2, you were the one adding in 2004 code to cope with various tcp_info sizes. So 12 years later, you cannot say it does not work anymore.