From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbcBICyQ (ORCPT ); Mon, 8 Feb 2016 21:54:16 -0500 Received: from ozlabs.org ([103.22.144.67]:32906 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbcBICyP (ORCPT ); Mon, 8 Feb 2016 21:54:15 -0500 Message-ID: <1454986452.17393.1.camel@ellerman.id.au> Subject: Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs From: Michael Ellerman To: Luis Henriques , Geoff Levand , Benjamin Herrenschmidt , Paul Mackerras Cc: Joe Perches , Geert Uytterhoeven , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Tue, 09 Feb 2016 13:54:12 +1100 In-Reply-To: <1454970427-23017-1-git-send-email-luis.henriques@canonical.com> References: <1454970427-23017-1-git-send-email-luis.henriques@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-08 at 22:27 +0000, Luis Henriques wrote: > Several network-related data structures are defined in gelic_udbg. > These could be easily dropped and the standard ones defined in network > headers could be used instead. > > The 4 patches that follow replace ethernet, vlan, ip and udp > structures in gelic_udbg. Note that this has been compile-tested > only. > > Changes since v1: > Include changes suggested by Joe Perches, namely the usage of > eth_broadcast_addr(), ETH_ALEN, ETH_P_8021Q and ETH_P_IP. > > Luis Henriques (4): > powerpc/ps3: gelic_udbg: use struct ethhdr from > powerpc/ps3: gelic_udbg: use struct vlan_hdr from > powerpc/ps3: gelic_udbg: use struct iphdr from > powerpc/ps3: gelic_udbg: use struct udphdr from These look good. But I don't have a setup to test them, does anyone? I'll merge them and hopefully someone can test them at some point. cheers