From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756516AbcBIEvH (ORCPT ); Mon, 8 Feb 2016 23:51:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44887 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756272AbcBIEux (ORCPT ); Mon, 8 Feb 2016 23:50:53 -0500 From: Jessica Yu To: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Petr Mladek , Rusty Russell , Steven Rostedt , Ingo Molnar Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu Subject: [PATCH v4 2/4] modules: set mod->state to MODULE_STATE_GOING before going notifiers are called Date: Mon, 8 Feb 2016 23:50:22 -0500 Message-Id: <1454993424-31031-3-git-send-email-jeyu@redhat.com> In-Reply-To: <1454993424-31031-1-git-send-email-jeyu@redhat.com> References: <1454993424-31031-1-git-send-email-jeyu@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In load_module(), the going notifiers are called during error handling when an error occurs after the coming notifiers have already been called. However, a module's state is still MODULE_STATE_COMING when the going notifiers are called in the error path. To be consistent, also set mod->state to MODULE_STATE_GOING before calling the going notifiers. Signed-off-by: Jessica Yu --- kernel/module.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/module.c b/kernel/module.c index a174335..77f6791 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3548,6 +3548,7 @@ static int load_module(struct load_info *info, const char __user *uargs, return do_init_module(mod); coming_cleanup: + mod->state = MODULE_STATE_GOING; blocking_notifier_call_chain(&module_notify_list, MODULE_STATE_GOING, mod); -- 2.4.3