From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756196AbcBIJYv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 04:24:51 -0500
Received: from ozlabs.org ([103.22.144.67]:52830 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756094AbcBIJYt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 04:24:49 -0500
Message-ID: <1455009881.13384.1.camel@ellerman.id.au>
Subject: Re: [PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline
 CPUs
From: Michael Ellerman <mpe@ellerman.id.au>
To: Steven Rostedt <rostedt@goodmis.org>,
        Denis Kirjanov <kda@linux-powerpc.org>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Date: Tue, 09 Feb 2016 20:24:41 +1100
In-Reply-To: <20160205093647.79ca2f70@gandalf.local.home>
References: <1450124286-4822-1-git-send-email-kda@linux-powerpc.org>
	 <1450124286-4822-2-git-send-email-kda@linux-powerpc.org>
	 <1452599615.20985.2.camel@ellerman.id.au>
	 <CAOJe8K2iVOy9=Ds09_ePct3xR6qCH0U4XoKW-qP_TNEMe8GAmQ@mail.gmail.com>
	 <CAOJe8K2Ahh-y95BmpsP+d2P9ysUsyo5CnhPOXymEJzjFwkR=7Q@mail.gmail.com>
	 <20160205093647.79ca2f70@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5-1ubuntu3.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-02-05 at 09:36 -0500, Steven Rostedt wrote:
> On Fri, 5 Feb 2016 14:20:17 +0300
> Denis Kirjanov <kda@linux-powerpc.org> wrote:
> > > > > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> > >
> > > Hi Steven,
> > >
> > > please apply with Michael's acked-by tag.
> >
> > ping
>
> Actually, can you take this through the ppc tree? The
> TRACE_EVENT_FN_COND is already in mainline.
>
> You can add my:
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Thanks, will do.

I tidied up the change log a bit:

    powerpc/pseries: Don't trace hcalls on offline CPUs

    If a cpu is hotplugged while the hcall trace points are active, it's
    possible to hit a warning from RCU due to the trace points calling into
    RCU from an offline cpu, eg:

      RCU used illegally from offline CPU!
      rcu_scheduler_active = 1, debug_locks = 1

    Make the hypervisor tracepoints conditional by using
    TRACE_EVENT_FN_COND.

    Acked-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>


cheers