From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756663AbcBISJR (ORCPT ); Tue, 9 Feb 2016 13:09:17 -0500 Received: from [165.204.55.251] ([165.204.55.251]:47214 "EHLO KellyTonga.amd.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753084AbcBISJP (ORCPT ); Tue, 9 Feb 2016 13:09:15 -0500 From: kelly.zytaruk@amd.com To: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kelly Zytaruk Subject: [PATCH] PCI: Support SRIOV on Legacy EndPoint device Date: Tue, 9 Feb 2016 13:08:58 -0500 Message-Id: <1455041338-3644-1-git-send-email-kelly.zytaruk@amd.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kelly Zytaruk It is not neccessary to check for PCI_EXP_TYPE in sriov_init(). There appears to be no reason for the check. Some AMD GPUs have hardware support for grapics SRIOV. If the GPU has a display output then the GPU needs to support Legacy VGA operation. If CLASS_CODE = VGA then the device should have a Port Type = Legacy EndPoint. Therefore in order to enable SRIOV on a GPU with a display output, LEGACY_END_POINT is supported as a valid Port Type by removing the check for Port Type. Patch is also logged in Bugzilla #112221 Signed-off-by: Kelly Zytaruk --- drivers/pci/iov.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 31f31d4..fe4bd0a 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -387,10 +387,6 @@ static int sriov_init(struct pci_dev *dev, int pos) struct resource *res; struct pci_dev *pdev; - if (pci_pcie_type(dev) != PCI_EXP_TYPE_RC_END && - pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT) - return -ENODEV; - pci_read_config_word(dev, pos + PCI_SRIOV_CTRL, &ctrl); if (ctrl & PCI_SRIOV_CTRL_VFE) { pci_write_config_word(dev, pos + PCI_SRIOV_CTRL, 0); -- 1.7.10.4