From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757176AbcBJJo0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 04:44:26 -0500
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:47343 "EHLO
	metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752151AbcBJJoW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 04:44:22 -0500
Message-ID: <1455097459.3597.3.camel@pengutronix.de>
Subject: Re: [PATCH] regulator: ltc3589: Make IRQ optional
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 10 Feb 2016 10:44:19 +0100
In-Reply-To: <1455048884-1143-1-git-send-email-bernhard@bwalle.de>
References: <1455048884-1143-1-git-send-email-bernhard@bwalle.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Dienstag, den 09.02.2016, 21:14 +0100 schrieb Bernhard Walle:
> It's perfectly valid to use the LTC3589 without an interrupt pin
> connected to it. Currently, the driver probing fails when client->irq
> is 0 (which means "no interrupt"). Don't register the interrupt
> handler in that case but successfully finish the device probing instead.
> 
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

I suggest these small changes:

[...]
> @@ -520,12 +520,14 @@ static int ltc3589_probe(struct i2c_client *client,
>  		}
>  	}
>  
> -	ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,
> -					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> -					client->name, ltc3589);
> -	if (ret) {
> -		dev_err(dev, "Failed to request IRQ: %d\n", ret);
> -		return ret;
> +	if (client->irq != 0) {

How about using
	if (client->irq) {
here ...

> +		ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,

... and reflowing this ...

> +						IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> +						client->name, ltc3589);
> +		if (ret) {
> +			dev_err(dev, "Failed to request IRQ %d: %d\n", client->irq, ret);

... and this long line.

regards
Philipp