From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nicolas.ferre@atmel.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe
Date: Wed, 10 Feb 2016 10:58:03 +0100 [thread overview]
Message-ID: <1455098283-14500-1-git-send-email-ludovic.desroches@atmel.com> (raw)
By putting the device in suspend at the end of the probe, it is
impossible to wake up on non software event such as card
insertion/removal.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
Hi,
Since I had no feedback on this topic:
http://permalink.gmane.org/gmane.linux.kernel.mmc/35160
I would like to no more put the device in suspend at the end of the probe. If
my device is suspended at the end of the probe, I have no issue to resume on
a software event such as mounting my sdcard but hardware event such as card
insertion and removal do not trigger a resume.
It seems there are only two sdhci drivers using runtime pm so maybe nobody has
noticed this issue.
Regards
Ludovic
drivers/mmc/host/sdhci-of-at91.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index 9cb86fb..ae24dea 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -210,8 +210,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
if (ret)
goto pm_runtime_disable;
- pm_runtime_put_autosuspend(&pdev->dev);
-
return 0;
pm_runtime_disable:
--
2.7.0
next reply other threads:[~2016-02-10 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:58 Ludovic Desroches [this message]
2016-02-10 11:50 ` Adrian Hunter
2016-02-10 12:51 ` Ludovic Desroches
2016-02-10 13:00 ` Adrian Hunter
2016-02-10 14:16 ` Ludovic Desroches
2016-02-10 14:20 ` Adrian Hunter
2016-02-10 15:34 ` Ludovic Desroches
2016-02-10 15:56 ` Ulf Hansson
2016-02-11 9:08 ` Ludovic Desroches
2016-02-11 9:46 ` Ulf Hansson
2016-02-11 11:05 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455098283-14500-1-git-send-email-ludovic.desroches@atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®