From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753260AbcBJRiS (ORCPT ); Wed, 10 Feb 2016 12:38:18 -0500 Received: from mail-qk0-f180.google.com ([209.85.220.180]:33717 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbcBJRiP (ORCPT ); Wed, 10 Feb 2016 12:38:15 -0500 From: Anton Protopopov To: "Yan, Zheng" , Sage Weil , Ilya Dryomov Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Protopopov Subject: [PATCH] ceph: fix a wrong comparison Date: Wed, 10 Feb 2016 12:38:03 -0500 Message-Id: <1455125883-27735-1-git-send-email-a.s.protopopov@gmail.com> X-Mailer: git-send-email 2.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A negative value rc compared to the positive value ENOENT in the finish_read() function. Signed-off-by: Anton Protopopov --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index c222137..1b809c9 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -276,7 +276,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg) for (i = 0; i < num_pages; i++) { struct page *page = osd_data->pages[i]; - if (rc < 0 && rc != ENOENT) + if (rc < 0 && rc != -ENOENT) goto unlock; if (bytes < (int)PAGE_CACHE_SIZE) { /* zero (remainder of) page */ -- 2.6.5