From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbcBJRue (ORCPT ); Wed, 10 Feb 2016 12:50:34 -0500 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35414 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbcBJRub (ORCPT ); Wed, 10 Feb 2016 12:50:31 -0500 From: Anton Protopopov To: Steve French Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Anton Protopopov Subject: [PATCH] cifs: fix erroneous return value Date: Wed, 10 Feb 2016 12:50:21 -0500 Message-Id: <1455126621-28052-1-git-send-email-a.s.protopopov@gmail.com> X-Mailer: git-send-email 2.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The setup_ntlmv2_rsp() function may return positive value ENOMEM instead of -ENOMEM in case of kmalloc failure. Signed-off-by: Anton Protopopov --- fs/cifs/cifsencrypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index afa09fc..e682b36 100644 --- a/fs/cifs/cifsencrypt.c +++ b/fs/cifs/cifsencrypt.c @@ -714,7 +714,7 @@ setup_ntlmv2_rsp(struct cifs_ses *ses, const struct nls_table *nls_cp) ses->auth_key.response = kmalloc(baselen + tilen, GFP_KERNEL); if (!ses->auth_key.response) { - rc = ENOMEM; + rc = -ENOMEM; ses->auth_key.len = 0; goto setup_ntlmv2_rsp_ret; } -- 2.6.5