From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751138AbcBJV1X (ORCPT ); Wed, 10 Feb 2016 16:27:23 -0500 Received: from smtprelay03.ispgateway.de ([80.67.31.41]:58407 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbcBJV1W (ORCPT ); Wed, 10 Feb 2016 16:27:22 -0500 From: Bernhard Walle To: lgirdwood@gmail.com, broonie@kernel.org Cc: linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Bernhard Walle Subject: [PATCH v2] regulator: ltc3589: Make IRQ optional Date: Wed, 10 Feb 2016 21:37:30 +0100 Message-Id: <1455136650-663-1-git-send-email-bernhard@bwalle.de> X-Mailer: git-send-email 2.7.1 X-Df-Sender: YmVybmhhcmRAYndhbGxlLmRl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's perfectly valid to use the LTC3589 without an interrupt pin connected to it. Currently, the driver probing fails when client->irq is 0 (which means "no interrupt"). Don't register the interrupt handler in that case but successfully finish the device probing instead. Signed-off-by: Bernhard Walle --- Changes between v1 and v2: - Use 'client->irq' instead of 'client->irq != 0' - Wrap long line - Don't print the IRQ number since that was leftover from my debugging drivers/regulator/ltc3589.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c index 972c386..47bef32 100644 --- a/drivers/regulator/ltc3589.c +++ b/drivers/regulator/ltc3589.c @@ -520,12 +520,15 @@ static int ltc3589_probe(struct i2c_client *client, } } - ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - client->name, ltc3589); - if (ret) { - dev_err(dev, "Failed to request IRQ: %d\n", ret); - return ret; + if (client->irq) { + ret = devm_request_threaded_irq(dev, client->irq, NULL, + ltc3589_isr, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + client->name, ltc3589); + if (ret) { + dev_err(dev, "Failed to request IRQ: %d\n", ret); + return ret; + } } return 0; -- 2.7.1