From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbcBKPbs (ORCPT ); Thu, 11 Feb 2016 10:31:48 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:64778 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbcBKPbq (ORCPT ); Thu, 11 Feb 2016 10:31:46 -0500 From: Arnd Bergmann To: Kukjin Kim , Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: exynos: clarify KEYBOARD_SAMSUNG selection Date: Thu, 11 Feb 2016 16:30:56 +0100 Message-Id: <1455204662-1017820-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:SH6qHbKVz2n6HOLD58kHyHi/AYC/Et9UUcSPQ76K2K1/nHOYuxJ 5lJsTwwkD3ijwwB/+/5IMG+g53bkwl/iCDmwiQTZEFrja90Ex0iyLgG4o3d251Ln7z+3Tx+ DJCZP7pQ/Qkm12o0dCc5I/n1c2G9jOnQbps7tIFU6A6uBXbjXeKmpkmBPBvKmdizoos7C5k +s4V9NOJf6JdbwA4VoYpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:MBWF1GmmUro=:c1dC7umpT0eWBVHA/vCRb9 b+uqMiFyMIvl1rZAv5FrozVEei7MkPzPEO8doQSou0cOLhc0SUWAuiqkXMnLD+5HPfO3pVSzc WsMXvJ7m4Ya2V95Y6Hijy2lFTLmDy44Qw5SFPEoKKEW2LCmWLtOqp2SwI+vFlYZFIl8BxDfWu e5Tt49oM3YRbOz9ikXmqpsruTFIlwtjgs7gElTl/990sPzxfq1eEaPjnTMDxN+VQWR991tcbf NMjXAZW3MZPg2fJPNP2z5P0JB4He4NBux8OO938hiWXv8DZWEUAKgOnO3t6XBXAjjKQHU0SY2 ZgcpEX/pSN4ccG6Hxi+eQM8LNAbp7TGDhs/QocfMoJtewWv8N27IwtO2Ue59G762KoCqpFC3D T0zl87KLEvEfbtjrxSVBRLlmFalfh2OVpaOpdZwuCPwLetP6bOCh2m2ZwvxKMHLnVN0NogSbI B33mIeiGzxk48kII/timnDseVdDRb2NyRyrumD0oPz8uL5nsMjAF4wjjQ61/GwaBEv9T6Ejr8 p4JwVYttKgm/NYpqXfT2BQ/InOLbOGJdpGuJadQAmX4ULamUszJsFBMI9+zaPQVsPYduYbroz uGwCRuKDlwfFHT7VyAlfINNMxGLS9CCDP3e9QYWhPr4cPolqqg+oYCa8XXjwYuWLckMloVktL RX7xHEWljpEwAnH7KQ2F+znJ2ylG5fAqSztkKp0KH3ODMyZMCVb3jUI3vaeKTON4zg3Y= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The samsung-keypad driver is implicitly selected by ARCH_EXYNOS4 (why?), but this fails if CONFIG_INPUT is a loadable module: drivers/input/built-in.o: In function `samsung_keypad_remove': drivers/input/keyboard/samsung-keypad.c:461: undefined reference to `input_unregister_device' drivers/input/built-in.o: In function `samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:137: undefined reference to `input_event' drivers/input/built-in.o: In function `samsung_keypad_irq': include/linux/input.h:389: undefined reference to `input_event' drivers/input/built-in.o: In function `samsung_keypad_probe': drivers/input/keyboard/samsung-keypad.c:358: undefined reference to `devm_input_allocate_device' drivers/input/built-in.o:(.debug_addr+0x34): undefined reference to `input_set_capability' This changes the 'select' statement so we don't do it if CONFIG_INPUT=m. The problem does not happen on mainline kernels, as we don't normally build built-in input drivers when CONFIG_INPUT=m, but I am experimenting with a patch to change this, and the samsung keypad driver showed up as one example that was silently broken before. Signed-off-by: Arnd Bergmann --- arch/arm/mach-exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 8434a0f6334c..b63e64581c24 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -59,7 +59,7 @@ config ARCH_EXYNOS4 select CLKSRC_SAMSUNG_PWM if CPU_EXYNOS4210 select CPU_EXYNOS4210 select GIC_NON_BANKED - select KEYBOARD_SAMSUNG if INPUT_KEYBOARD + select KEYBOARD_SAMSUNG if INPUT=y && INPUT_KEYBOARD select MIGHT_HAVE_CACHE_L2X0 help Samsung EXYNOS4 (Cortex-A9) SoC based systems -- 2.7.0