From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbcBKPoB (ORCPT ); Thu, 11 Feb 2016 10:44:01 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:64284 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbcBKPn6 (ORCPT ); Thu, 11 Feb 2016 10:43:58 -0500 From: Arnd Bergmann To: Greg Kroah-Hartman , Masahiro Yamada Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Paul Gortmaker , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build Date: Thu, 11 Feb 2016 16:41:30 +0100 Message-Id: <1455205297-1021302-5-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1455205297-1021302-1-git-send-email-arnd@arndb.de> References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:+OdHMwYxpXyizvCOsX6EdsAEr/Tn2WUBMuHkrTYRcJaOivSw2Rh iS4f4KGYgv0c+P9YfXoPIYhjjCRrM7svVYIlewEcp9PIq4rJ2LLMT1zBvtSGVZRturt+lgc xoHbwKWTQMIG0KachdP2F6eG971ienCKzBfi452jRPs500NVwH6UPn1TPxdvCihpOkgp823 rxwCOQCiBX06cfSzbFnqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rJtq9ElPKGw=:5AfhWJwuv/Swf4WE70H4lX JCZ9Q3sLn1W78lsn2ssCVY9Ucfx/bpbnoljJd1zXjkB0lfwpGyXTdLHo6M7bdzqvu3xCmg48c qxmyvGH6s0Lr/3QWeWVax3n33UNrAwsvCI0/ASDfcUiMBPL8CE/9vCKIo0EYegsTwEYVXztI7 A1omQbMkuR29bhd6Jct6w3obhlvPJ8mUVrtShYMjxhbsQG7Pw3TudHf0z5nSa5OKaqEPKxqFB GBfOm+MlZbqs9RzYUTvqAVzdoV8rSK9xosRguk0mzXnnroCfn/pN0AWOkIq/HQNKKZETNPaPY NhX5PXmPk45AIE5VnjujB7CS/1R28F1wqiRAbdhIdsmAhymFp9IXZMZV9O9PpVMCLYINkjKCM Xco0qGk12LcKrBdgw4JJ3mT4oFkt61Ntv27gYTGi+hQ56vj8QDnYJJX9WyT8OrWBPS3MyLEJY 5YTFt7iZTXPMjQruCYRFeig1AtYdPu5Ebb/PGag0eu7J6eVbaiUDH45tp+7vI25zoz/M6n70I dKd/zr3FbSSaPHlgz4m4uhVLs4W7DIhrFQOrmEctrP1yfWQGUEZRCYjl2Q2ZA5pTu/i6Amnai vp1kgv+5mxjtj+NuDWBbWhZnmyh9ThzHfYKJ5ElTOFu/4YO3IeYTdHCG6voJYn5XBF2tBHItd AqcQETBKzoMF+wQRU7QjeNaOB67BYOHrcWfPw3KjULJbCAZL4TH8VVThwHR7YyG00cx4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added uniphier serial port driver fails to build as a loadable module when the base 8250 driver is built-in and its console support enabled: ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined! This changes the driver to only provide the early console support if it is built-in itself as well. Signed-off-by: Arnd Bergmann --- drivers/tty/serial/8250/8250_uniphier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c index bab6b3ae2540..1b7bd26555b7 100644 --- a/drivers/tty/serial/8250/8250_uniphier.c +++ b/drivers/tty/serial/8250/8250_uniphier.c @@ -35,7 +35,7 @@ struct uniphier8250_priv { spinlock_t atomic_write_lock; }; -#ifdef CONFIG_SERIAL_8250_CONSOLE +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE) static int __init uniphier_early_console_setup(struct earlycon_device *device, const char *options) { -- 2.7.0