mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Andi Shyti <andi.shyti@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall
Date: Fri, 12 Feb 2016 01:30:17 -0300	[thread overview]
Message-ID: <1455251419-8919-3-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1455251419-8919-1-git-send-email-javier@osg.samsung.com>

The driver's init and exit function don't do anything besides adding and
deleting the I2C driver so the module_i2c_driver() macro could be used.

Currently is not being used because the driver is initialized at subsys
initcall level, claiming that this is done to allow consumers devices to
use the resources provided by this driver. But dependencies should be in
the DT and consumers drivers should not rely in the registration order.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/mfd/max77686.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
index 1f30c97d6d4e..2f563d0f83cc 100644
--- a/drivers/mfd/max77686.c
+++ b/drivers/mfd/max77686.c
@@ -400,18 +400,7 @@ static struct i2c_driver max77686_i2c_driver = {
 	.id_table = max77686_i2c_id,
 };
 
-static int __init max77686_i2c_init(void)
-{
-	return i2c_add_driver(&max77686_i2c_driver);
-}
-/* init early so consumer devices can complete system boot */
-subsys_initcall(max77686_i2c_init);
-
-static void __exit max77686_i2c_exit(void)
-{
-	i2c_del_driver(&max77686_i2c_driver);
-}
-module_exit(max77686_i2c_exit);
+module_i2c_driver(max77686_i2c_driver);
 
 MODULE_DESCRIPTION("MAXIM 77686/802 multi-function core driver");
 MODULE_AUTHOR("Chiwoong Byun <woong.byun@samsung.com>");
-- 
2.5.0

  parent reply	other threads:[~2016-02-12  4:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12  4:30 [PATCH 0/4] mfd: max77686: Allow the driver to be built as a module Javier Martinez Canillas
2016-02-12  4:30 ` [PATCH 1/4] mfd: max77686: Add max77802 to I2C device ID table Javier Martinez Canillas
2016-02-15  5:21   ` Krzysztof Kozlowski
2016-03-08  4:24   ` Lee Jones
2016-02-12  4:30 ` Javier Martinez Canillas [this message]
2016-02-15  6:54   ` [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Krzysztof Kozlowski
2016-02-15  8:21     ` Lee Jones
2016-02-15 15:21     ` Javier Martinez Canillas
2016-02-15 23:20       ` Krzysztof Kozlowski
2016-02-16 20:45         ` Javier Martinez Canillas
2016-02-17  7:49           ` Krzysztof Kozlowski
2016-02-17 18:38             ` Javier Martinez Canillas
2016-02-17  9:27         ` Marek Szyprowski
2016-02-17  9:34           ` Krzysztof Kozlowski
2016-02-12  4:30 ` [PATCH 3/4] mfd: max77686: Allow driver to be built as a module Javier Martinez Canillas
2016-03-08  4:11   ` Lee Jones
2016-02-12  4:30 ` [PATCH 4/4] mfd: max77686: Export OF module alias information Javier Martinez Canillas
2016-02-15  6:55   ` Krzysztof Kozlowski
2016-03-08  4:24   ` Lee Jones
2016-02-15  7:04 ` [PATCH 0/4] mfd: max77686: Allow the driver to be built as a module Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455251419-8919-3-git-send-email-javier@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=andi.shyti@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®