From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcBLRfJ (ORCPT ); Fri, 12 Feb 2016 12:35:09 -0500 Received: from smtprelay0007.hostedemail.com ([216.40.44.7]:55245 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751262AbcBLRfH (ORCPT ); Fri, 12 Feb 2016 12:35:07 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3870:4321:5007:6261:7901:7903:10004:10400:10848:11026:11232:11657:11658:11914:12043:12048:12296:12517:12519:12740:13069:13255:13311:13357:13894:14659:21080:30012:30054:30060:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: wound53_497abd4719c61 X-Filterd-Recvd-Size: 1676 Message-ID: <1455298503.4235.4.camel@perches.com> Subject: Re: [PATCH 06/11] staging: lustre: add missing spaces for LNet layer reported by checkpatch.pl From: Joe Perches To: James Simmons , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Dorkin Cc: Linux Kernel Mailing List , Lustre Development List Date: Fri, 12 Feb 2016 09:35:03 -0800 In-Reply-To: <1455296769-5481-7-git-send-email-jsimmons@infradead.org> References: <1455296769-5481-1-git-send-email-jsimmons@infradead.org> <1455296769-5481-7-git-send-email-jsimmons@infradead.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-02-12 at 12:06 -0500, James Simmons wrote: > Add missing spaces in the code reported by checkpatch.pl. [] > diff --git a/drivers/staging/lustre/include/linux/lnet/lib-types.h b/drivers/staging/lustre/include/linux/lnet/lib-types.h [] > @@ -112,7 +112,7 @@ typedef struct lnet_libhandle { >  } lnet_libhandle_t; >   >  #define lh_entry(ptr, type, member) \ > - ((type *)((char *)(ptr)-(char *)(&((type *)0)->member))) > + ((type *)((char *)(ptr) - (char *)(&((type *)0)->member))) This could use offsetof(type, member)