From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbcBMXUt (ORCPT ); Sat, 13 Feb 2016 18:20:49 -0500 Received: from mail1.windriver.com ([147.11.146.13]:37281 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbcBMXUs (ORCPT ); Sat, 13 Feb 2016 18:20:48 -0500 From: Paul Gortmaker To: CC: , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Riley Andrews , Paul Gortmaker , Gustavo Padovan , Maarten Lankhorst , Greg Kroah-Hartman Subject: [PATCH] drivers/staging/android: don't use modular references in sync_debug.c Date: Sat, 13 Feb 2016 18:20:17 -0500 Message-ID: <1455405617-14159-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.6.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 8a0044846115e74552b671a7073cffeec14b9316 ("staging/android: create a 'sync' dir for debugfs information"), modular references were introduced to this file. However if we look, we find: drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o drivers/staging/android/Kconfig:config SYNC drivers/staging/android/Kconfig: bool "Synchronization framework" This file isn't currently buildable as a module, and hence the code for module_exit is just dead code. Remove it and the module.h include. Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Greg Kroah-Hartman Signed-off-by: Paul Gortmaker --- drivers/staging/android/sync_debug.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c index fd13f1e885e5..5a7ec58fbc09 100644 --- a/drivers/staging/android/sync_debug.c +++ b/drivers/staging/android/sync_debug.c @@ -15,7 +15,6 @@ */ #include -#include #include #include #include @@ -335,13 +334,6 @@ static __init int sync_debugfs_init(void) } late_initcall(sync_debugfs_init); -static __exit void sync_debugfs_exit(void) -{ - if (dbgfs) - debugfs_remove_recursive(dbgfs); -} -module_exit(sync_debugfs_exit); - #define DUMP_CHUNK 256 static char sync_dump_buf[64 * 1024]; void sync_dump(void) -- 2.6.1