From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
Ed Wildgoose <kernel@wildgooses.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Philip Prindeville <philipp@redfish-solutions.com>,
Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>
Subject: [PATCH 0/5] x86: remove modular references from non modular code
Date: Sun, 14 Feb 2016 18:09:51 -0500 [thread overview]
Message-ID: <1455491396-30977-1-git-send-email-paul.gortmaker@windriver.com> (raw)
My audit of i386 allmodconfig found these instances of non-modular
code needlessly using the modular equivalents of their built-in
counterparts.
In fixing that, we get rid of some dead code, make the mandate of
the remaining code more clear, and leave behind better examples
for future platform code to copy/emulate.
Several of them are trivial, in that there is no binary output
change. A couple others have dead code removal so the binary
output will be slightly smaller. We've done a direct mapping
of module_init --> device_initcall in each instance, so there is
no initcall reordering risks here. Overall, in all cases, the
runtime should be completely unchanged.
Where others have deployed module_param() already, we have to
leave it, because there is no equivalent builtin_param (not yet)
and we have to remain compatible with existing bootarg users.
Paul.
---
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Ed Wildgoose <kernel@wildgooses.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Philip Prindeville <philipp@redfish-solutions.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org
Paul Gortmaker (5):
x86: make platform/intel-quark/imr.c explicitly non-modular
x86: make platform/intel-quark/imr_selftest.c explicitly non-modular
x86: make platform/geode/geos.c explicitly non-modular
x86: make platform/geode/alix.c explicitly non-modular
x86: make platform/geode/net5501.c explicitly non-modular
arch/x86/platform/geode/alix.c | 14 +++++------
arch/x86/platform/geode/geos.c | 8 +------
arch/x86/platform/geode/net5501.c | 8 +------
arch/x86/platform/intel-quark/imr.c | 35 ++--------------------------
arch/x86/platform/intel-quark/imr_selftest.c | 15 ++----------
5 files changed, 13 insertions(+), 67 deletions(-)
--
2.6.1
next reply other threads:[~2016-02-14 23:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 23:09 Paul Gortmaker [this message]
2016-02-14 23:09 ` [PATCH 1/5] x86: make platform/intel-quark/imr.c explicitly non-modular Paul Gortmaker
2016-02-15 9:27 ` Bryan O'Donoghue
2016-02-16 12:12 ` [tip:x86/platform] x86/platform: Make platform/intel-quark/ imr.c " tip-bot for Paul Gortmaker
2016-02-14 23:09 ` [PATCH] x86: make platform/intel-quark/imr_selftest.c " Paul Gortmaker
2016-02-15 9:27 ` Bryan O'Donoghue
2016-02-16 12:13 ` [tip:x86/platform] x86/platform: Make platform/intel-quark/ imr_selftest.c " tip-bot for Paul Gortmaker
2016-02-14 23:09 ` [PATCH 3/5] x86: make platform/geode/geos.c " Paul Gortmaker
2016-02-16 12:13 ` [tip:x86/platform] x86/platform: Make platform/geode/ geos.c " tip-bot for Paul Gortmaker
2016-02-14 23:09 ` [PATCH 4/5] x86: make platform/geode/alix.c " Paul Gortmaker
2016-02-16 12:13 ` [tip:x86/platform] x86/platform: Make platform/geode/ alix.c " tip-bot for Paul Gortmaker
2016-02-14 23:09 ` [PATCH 5/5] x86: make platform/geode/net5501.c " Paul Gortmaker
2016-02-16 12:14 ` [tip:x86/platform] x86/platform: Make platform/geode/ net5501.c " tip-bot for Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455491396-30977-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=hpa@zytor.com \
--cc=kernel@wildgooses.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=philipp@redfish-solutions.com \
--cc=pure.logic@nexus-software.ie \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome