From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Aaron Lu <aaron.lu@intel.com>, Huang Ying <ying.huang@intel.com>,
Josh Triplett <josh@joshtriplett.org>,
Len Brown <lenb@kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
<linux-acpi@vger.kernel.org>
Subject: [PATCH 0/3] acpi: remove modular references from non modular code
Date: Mon, 15 Feb 2016 00:27:48 -0500 [thread overview]
Message-ID: <1455514071-26368-1-git-send-email-paul.gortmaker@windriver.com> (raw)
An audit of i386/x86_64 allmodconfig builds found these instances of
non-modular ACPI code needlessly using the modular equivalents of
their built-in counterparts.
In fixing that, we get rid of some dead code, make the mandate of
the remaining code more clear, and leave behind better examples
for future ACPI code to copy/emulate.
Two of them are trivial, in that there is no binary output change.
The other has dead code removal so the binary output will be
slightly smaller. We've done a direct mapping of module_init to
device_initcall in each instance, so there is no initcall
reordering risks here. Overall, in all cases, the runtime should
be completely unchanged.
Where others have deployed module_param() already, we have to
leave it, because there is no equivalent builtin_param (not yet)
and we have to remain compatible with existing bootarg users.
Paul.
---
Cc: Aaron Lu <aaron.lu@intel.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org
Paul Gortmaker (3):
drivers/acpi: make bgrt driver explicitly non-modular
drivers/acpi: make apei/ghes.c more explicitly non-modular
drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
drivers/acpi/apei/ghes.c | 23 +++++++----------------
drivers/acpi/bgrt.c | 10 +++-------
drivers/acpi/pmic/intel_pmic_crc.c | 7 ++-----
3 files changed, 12 insertions(+), 28 deletions(-)
--
2.6.1
next reply other threads:[~2016-02-15 5:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:27 Paul Gortmaker [this message]
2016-02-15 5:27 ` [PATCH 1/3] drivers/acpi: make bgrt driver explicitly non-modular Paul Gortmaker
2016-02-15 5:27 ` [PATCH 2/3] drivers/acpi: make apei/ghes.c more " Paul Gortmaker
2016-02-15 5:27 ` [PATCH 3/3] drivers/acpi: make pmic/intel_pmic_crc.c " Paul Gortmaker
2016-02-16 2:52 ` Aaron Lu
2016-02-17 2:27 ` Zheng, Lv
2016-02-16 19:29 ` [PATCH 0/3] acpi: remove modular references from non modular code Rafael J. Wysocki
2016-02-17 2:24 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455514071-26368-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=aaron.lu@intel.com \
--cc=josh@joshtriplett.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome