From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753236AbcBONW3 (ORCPT ); Mon, 15 Feb 2016 08:22:29 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37007 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbcBONW1 (ORCPT ); Mon, 15 Feb 2016 08:22:27 -0500 From: Thierry Reding To: Greg Kroah-Hartman Cc: "J . German Rivera" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: fsl-mc: Avoid section mismatch Date: Mon, 15 Feb 2016 14:22:23 +0100 Message-Id: <1455542543-21303-2-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 2.7.1 In-Reply-To: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com> References: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding The fsl_mc_allocator_driver_exit() function is marked __exit, but is called by the error handling code in fsl_mc_allocator_driver_init(). This results in a section mismatch, which in turn could lead to executing random code. Remove the __exit annotation to fix this. Cc: J. German Rivera Cc: Greg Kroah-Hartman Signed-off-by: Thierry Reding --- drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +- drivers/staging/fsl-mc/include/mc-private.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c b/drivers/staging/fsl-mc/bus/mc-allocator.c index c5fa628411ec..86f8543c2b9a 100644 --- a/drivers/staging/fsl-mc/bus/mc-allocator.c +++ b/drivers/staging/fsl-mc/bus/mc-allocator.c @@ -756,7 +756,7 @@ int __init fsl_mc_allocator_driver_init(void) return fsl_mc_driver_register(&fsl_mc_allocator_driver); } -void __exit fsl_mc_allocator_driver_exit(void) +void fsl_mc_allocator_driver_exit(void) { fsl_mc_driver_unregister(&fsl_mc_allocator_driver); } diff --git a/drivers/staging/fsl-mc/include/mc-private.h b/drivers/staging/fsl-mc/include/mc-private.h index be72a44ba064..ee5f1d2bf604 100644 --- a/drivers/staging/fsl-mc/include/mc-private.h +++ b/drivers/staging/fsl-mc/include/mc-private.h @@ -123,7 +123,7 @@ void dprc_driver_exit(void); int __init fsl_mc_allocator_driver_init(void); -void __exit fsl_mc_allocator_driver_exit(void); +void fsl_mc_allocator_driver_exit(void); int __must_check fsl_mc_resource_allocate(struct fsl_mc_bus *mc_bus, enum fsl_mc_pool_type pool_type, -- 2.7.1