From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589AbcBOOiX (ORCPT ); Mon, 15 Feb 2016 09:38:23 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:23918 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382AbcBOOgp (ORCPT ); Mon, 15 Feb 2016 09:36:45 -0500 X-AuditID: cbfec7f5-f79b16d000005389-c7-56c1e27a717e From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Ludovic Desroches , Guennadi Liakhovetski , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 4/7] atmel-isi: fix IS_ERR_VALUE usage Date: Mon, 15 Feb 2016 15:35:22 +0100 Message-id: <1455546925-22119-5-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKLMWRmVeSWpSXmKPExsVy+t/xq7pVjw6GGXQd1bS4te4cq8XGGetZ Ld5vnMdkcXnXHDaLng1bWS0OzUy2WHvkLrvF6mcVDhweC35tZfH48DHOY0v/XXaPvi2rGD0+ b5ILYI3isklJzcksSy3St0vgyjizYwJzwT7Oip7eyywNjD/Yuxg5OSQETCQaZ5yEssUkLtxb z9bFyMUhJLCUUeLRg6usEE4Tk8TL1iY2kCo2AU2Jv5tvgtkiAgoSm3ufsYLYzAKHmCQmzTIH sYUFzCQOvP4EFmcRUJX42baYCcTmFXCWOLmwjwVim5zEyWOTgWo4ODgFXCQW7C0ACQsBlezf vY1pAiPvAkaGVYyiqaXJBcVJ6blGesWJucWleel6yfm5mxghgfV1B+PSY1aHGAU4GJV4eCPO HAgTYk0sK67MPcQowcGsJMJrcfpgmBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeW pGanphakFsFkmTg4pRoYt1Q9N9n6mVl4VXtjoUb3pui2Tew7JhpmvTxzfBmP6un5nxdp2sVt 3LMyWUx/S8yTWIYqv1NeBtMbdGfu94z/dn3FxyUTD8XsUVgnMvv5/vsPX5yyYzu05Ou1ZdZm 5bxvlZ4ynDZ/5Cqgol7bWXV9eqB7Uo5y1KOF7g9bl2+I9kxYcvjrrfaFD5VYijMSDbWYi4oT AXi00KMoAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IS_ERR_VALUE macro should be used only with unsigned long type. For signed types comparison 'ret < 0' should be used. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda --- drivers/media/platform/soc_camera/atmel-isi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 1af779e..ab2d9b9 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -1026,7 +1026,7 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi, static int atmel_isi_probe(struct platform_device *pdev) { - unsigned int irq; + int irq; struct atmel_isi *isi; struct resource *regs; int ret, i; @@ -1086,7 +1086,7 @@ static int atmel_isi_probe(struct platform_device *pdev) isi->width_flags |= 1 << 9; irq = platform_get_irq(pdev, 0); - if (IS_ERR_VALUE(irq)) { + if (irq < 0) { ret = irq; goto err_req_irq; } -- 1.9.1