From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcBPCFD (ORCPT ); Mon, 15 Feb 2016 21:05:03 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:23878 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbcBPCFA (ORCPT ); Mon, 15 Feb 2016 21:05:00 -0500 X-AuditID: cbfec7f5-f79b16d000005389-aa-56c283c8968e From: Krzysztof Kozlowski To: Sangbeom Kim , Krzysztof Kozlowski , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Cc: Denys Vlasenko Subject: [PATCH] rtc: s5m: De-inline large functions to save space Date: Tue, 16 Feb 2016 11:04:42 +0900 Message-id: <1455588282-7251-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 2.5.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmluLIzCtJLcpLzFFi42I5/e/4Nd0TzYfCDFY26FssuXiV3aLj2mIm i9cvDC0u75rDZjHj/D4mi/2dHYwWF1d8YbLY+fABowOHx5NNFxk99kw8yebxdMJkdo++LasY PabP+8nk8XmTXABbFJdNSmpOZllqkb5dAlfGwQ/7WQtOClRsWHyQtYGxma+LkZNDQsBEYuPl XiYIW0ziwr31bF2MXBxCAksZJd7tvskK4fxnlJi25TgjSBWbgLHE5uVLwKpEBOYzSTy7dJm5 i5GDg1lAV+LhK22QGmEBJ4nPW68wg9gsAqoSfYtWsICU8Aq4SfxcYQRiSgjISSy4kD6BkXsB I8MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJCg+bqDcekxq0OMAhyMSjy8G1wPhQmxJpYV V+YeYpTgYFYS4b0aBhTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKY LBMHp1QDo9GB5Ta3Z8+PKnSMaftgcFJqw+WNhoVVF/WkbNelLJvXX5VzwrHxw32FWQEx71e3 NK80ZdEq8lvdzbx2jsqLVQFXtexsOsMXPU3VY0o0nnr8iQrbma5V27derH7bwJV6v608SUil qdXIIm1ZnVZ8SsbUu9/4/xaqizSeOVX7a5NultnM5VXLlViKMxINtZiLihMBLhepWBYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Few functions were marked inline even though they were relatively large and sometimes used in multiple places. De-inline them to let the compiler decide whether optimization makes sense. This fixes inline_hunt report: drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes Reported-by: Denys Vlasenko Cc: Denys Vlasenko Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-s5m.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 7407d7394bb4..0477678d968f 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -216,7 +216,7 @@ static int s5m8767_tm_to_data(struct rtc_time *tm, u8 *data) * Read RTC_UDR_CON register and wait till UDR field is cleared. * This indicates that time/alarm update ended. */ -static inline int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) +static int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) { int ret, retry = UDR_READ_RETRY_CNT; unsigned int data; @@ -231,7 +231,7 @@ static inline int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) return ret; } -static inline int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, +static int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, struct rtc_wkalrm *alarm) { int ret; @@ -264,7 +264,7 @@ static inline int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, return 0; } -static inline int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) +static int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) { int ret; unsigned int data; @@ -288,7 +288,7 @@ static inline int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) return ret; } -static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) +static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) { int ret; unsigned int data; -- 2.5.0