From: "Michał Kępień" <kernel@kempniu.pl>
To: "Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>
Cc: Darek Stojaczyk <darek.stojaczyk@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/5] Process Dell Instant Launch hotkey on Vostro V131 and Inspiron M5110
Date: Tue, 16 Feb 2016 15:50:25 +0100 [thread overview]
Message-ID: <1455634230-1487-1-git-send-email-kernel@kempniu.pl> (raw)
In-Reply-To: <20160121090401.GR7192@pali>
Changes from v2:
- Use a static variable instead of a quirk structure
- Use the API exported by dell-smbios to issue the SMBIOS request
required for generating WMI events, returning with error from
dell_wmi_init() if it fails
- Move dell_smi_error() from dell-laptop to dell-smbios and use it to
determine the error code for returning from dell_wmi_init() when
enabling WMI fails
- Support Dell Inspiron M5110
Changes from v1:
- Use DMI matching instead of a module parameter
- Change flag name to improve readability
This patch series makes use of the API exported by dell-smbios, so it
should be applied to either testing or dell-smbios.
This patch series was tested on a Dell Inspiron M5110 by Darek Stojaczyk
(CC'd), who reported that it had similar issues as Dell Vostro V131 back
in July 2015 [1].
Pali, returning to our debate whether to place the WMI-enabling SMBIOS
request in dell-laptop or in dell-wmi, I still strongly recommend the
latter. Apart from the reasons I had discussed before [2], I came up
with another one. The SMBIOS request in question registers/unregisters
an event listener (dell-wmi). If we only register for WMI events in
dell-laptop and dell-wmi gets unloaded at some point further on,
brightness keys will not be properly processed any more as they will
only be reported using WMI. If we properly unregister in
dell_wmi_exit(), brightness keys will be properly reported by ACPI as if
dell-wmi was never loaded.
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1205791/comments/12
[2] http://www.spinics.net/lists/platform-driver-x86/msg08289.html
drivers/platform/x86/Kconfig | 1 +
drivers/platform/x86/dell-laptop.c | 30 +++++------------
drivers/platform/x86/dell-smbios.c | 16 +++++++++
drivers/platform/x86/dell-smbios.h | 2 ++
drivers/platform/x86/dell-wmi.c | 63 +++++++++++++++++++++++++++++++++++-
5 files changed, 89 insertions(+), 23 deletions(-)
--
1.7.10.4
next prev parent reply other threads:[~2016-02-16 14:50 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 14:18 [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing Michał Kępień
2015-11-26 14:41 ` Pali Rohár
2015-11-26 14:55 ` Michał Kępień
2015-11-29 19:50 ` Pali Rohár
2015-11-30 14:14 ` Michał Kępień
2015-11-30 14:37 ` Pali Rohár
2015-11-30 14:54 ` Michał Kępień
2015-11-30 20:55 ` Darren Hart
2015-11-30 21:15 ` Darren Hart
2015-12-01 8:47 ` Michał Kępień
2015-12-01 19:51 ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień
2015-12-04 1:16 ` Darren Hart
2015-12-04 8:56 ` Pali Rohár
2015-12-04 13:27 ` Michał Kępień
2016-01-11 19:12 ` Darren Hart
2016-01-11 20:07 ` Pali Rohár
2016-01-21 9:04 ` Pali Rohár
2016-01-21 10:52 ` Michał Kępień
2016-01-21 13:44 ` Pali Rohár
2016-01-21 14:56 ` Michał Kępień
2016-01-21 15:42 ` Pali Rohár
2016-01-22 11:08 ` Michał Kępień
2016-02-16 14:50 ` Michał Kępień [this message]
2016-02-16 14:50 ` [PATCH v3 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-02-16 14:50 ` [PATCH v3 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-02-16 14:50 ` [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-02-16 15:17 ` Pali Rohár
2016-02-16 21:53 ` Michał Kępień
2016-02-20 1:24 ` Darren Hart
2016-02-22 8:56 ` Michał Kępień
2016-02-22 9:03 ` Pali Rohár
2016-02-22 9:13 ` Michał Kępień
2016-02-22 21:17 ` Darren Hart
2016-02-16 14:50 ` [PATCH v3 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-02-16 14:50 ` [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-02-16 15:22 ` Pali Rohár
2016-02-16 22:03 ` Michał Kępień
2016-02-17 11:42 ` Pali Rohár
2016-02-17 12:01 ` Michał Kępień
2016-02-17 12:08 ` Pali Rohár
2016-02-18 8:25 ` Michał Kępień
2016-02-24 7:20 ` [PATCH v4 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień
2016-02-24 7:20 ` [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-02-29 12:52 ` Pali Rohár
2016-02-29 20:22 ` Michał Kępień
2016-02-29 20:24 ` Pali Rohár
2016-02-29 20:41 ` Michał Kępień
2016-02-29 22:50 ` Darren Hart
2016-03-02 11:49 ` Michał Kępień
2016-03-03 11:38 ` Pali Rohár
2016-02-24 7:20 ` [PATCH v4 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-02-29 12:53 ` Pali Rohár
2016-02-24 7:20 ` [PATCH v4 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-02-29 12:57 ` Pali Rohár
2016-02-24 7:20 ` [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-02-29 12:59 ` Pali Rohár
2016-02-29 20:31 ` Michał Kępień
2016-02-29 20:39 ` Pali Rohár
2016-02-29 20:49 ` Michał Kępień
2016-02-29 20:56 ` Pali Rohár
2016-02-29 23:00 ` Darren Hart
2016-03-02 12:35 ` Michał Kępień
2016-03-03 17:16 ` Darren Hart
2016-03-03 18:46 ` Michał Kępień
2016-03-03 20:47 ` Darren Hart
2016-02-29 23:00 ` Darren Hart
2016-02-24 7:20 ` [PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-02-29 13:00 ` Pali Rohár
2016-03-04 13:09 ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień
2016-03-04 13:09 ` [PATCH v5 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-03-04 13:09 ` [PATCH v5 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-03-04 13:09 ` [PATCH v5 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-03-04 13:09 ` [PATCH v5 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-03-04 13:09 ` [PATCH v5 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-03-07 8:27 ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Pali Rohár
2016-03-08 11:20 ` Darren Hart
2015-12-04 12:55 ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień
2015-12-04 16:04 ` Andy Lutomirski
2015-12-04 8:48 ` Pali Rohár
2015-12-04 12:36 ` Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455634230-1487-1-git-send-email-kernel@kempniu.pl \
--to=kernel@kempniu.pl \
--cc=darek.stojaczyk@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome