From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbaBRWV3 (ORCPT ); Tue, 18 Feb 2014 17:21:29 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:53776 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752941AbaBRWV1 (ORCPT ); Tue, 18 Feb 2014 17:21:27 -0500 From: "Rafael J. Wysocki" To: Stephen Warren Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nm@ti.com, kgene.kim@samsung.com, jinchoi@broadcom.com, tianyu.lan@intel.com, sebastian.capella@linaro.org, jhbird.choi@samsung.com Subject: Re: [PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() Date: Tue, 18 Feb 2014 23:36:16 +0100 Message-ID: <1455643.Gytp1zkkCW@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.13.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5303C2FC.8040508@wwwdotorg.org> References: <5303C2FC.8040508@wwwdotorg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, February 18, 2014 01:30:52 PM Stephen Warren wrote: > On 02/17/2014 02:25 AM, Viresh Kumar wrote: > > This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}() > > for handling suspend/resume of cpufreq governors and core. > > > > There are multiple problems that are fixed by this patch: > > - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board > > wasn't working well with suspend/resume as calls for removing non-boot CPUs > > was turning out into a call to drivers ->target() which then tries to play > > with regulators. But regulators and their I2C bus were already suspended and > > this resulted in a failure. Many platforms have such problems, samsung, tegra, > > etc.. They solved it with driver specific PM notifiers where they used to > > disable their driver's ->target() routine. > > - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables > > configuration for clusters/sockets with non-boot CPUs was getting lost after > > suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on > > removal of the last cpu for that policy and so deallocating memory for > > tunables. This is fixed by this patch as we don't allow any operation on > > governors after device suspend and before device resume now. > > The series, > Tested-by: Stephen Warren Is this series necessary to fix bugs that you're seeing in 3.14-rc and if so, the what bugs are they? > Patch 7/7, > Acked-by: Stephen Warren > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.