From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933136AbcBPSq3 (ORCPT ); Tue, 16 Feb 2016 13:46:29 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:40702 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932948AbcBPSq1 (ORCPT ); Tue, 16 Feb 2016 13:46:27 -0500 Message-ID: <1455648364.1143.12.camel@decadent.org.uk> Subject: Re: [PATCH 4.4 112/117] rtlwifi: rtl8821ae: Fix errors in parameter initialization From: Ben Hutchings To: Larry Finger Cc: stable@vger.kernel.org, Kalle Valo , Greg Kroah-Hartman , LKML Date: Tue, 16 Feb 2016 18:46:04 +0000 In-Reply-To: <20160214222144.781798389@linuxfoundation.org> References: <20160214222141.393531627@linuxfoundation.org> <20160214222144.781798389@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-OdPGCVLdZvYpLHg06H00" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:b06c:6b7a:5449:a1ad X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-OdPGCVLdZvYpLHg06H00 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2016-02-14 at 14:22 -0800, Greg Kroah-Hartman wrote: > 4.4-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Larry Finger >=20 > commit 78bae1de422a7f6f2b4b61f6a5c379e3d7f96f44 upstream. >=20 > This driver failed to copy parameters sw_crypto and disable_watchdog into > the locations actually used by the driver. In addition, msi_support was > initialized three times and one of them used the wrong variable. The > initialization of parameter int_clear was moved so that it is near that > of the rest of the parameters. >=20 > Signed-off-by: Larry Finger > Signed-off-by: Kalle Valo > Signed-off-by: Greg Kroah-Hartman >=20 > --- > =C2=A0drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c |=C2=A0=C2=A0= =C2=A0=C2=A09 +++++---- > =C2=A01 file changed, 5 insertions(+), 4 deletions(-) >=20 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c [...] > @@ -168,12 +166,15 @@ int rtl8821ae_init_sw_vars(struct ieee80 > =C2=A0 rtlpriv->psc.swctrl_lps =3D rtlpriv->cfg->mod_params->swctrl_lps; > =C2=A0 rtlpriv->psc.fwctrl_lps =3D rtlpriv->cfg->mod_params->fwctrl_lps; > =C2=A0 rtlpci->msi_support =3D rtlpriv->cfg->mod_params->msi_support; > - rtlpci->msi_support =3D rtlpriv->cfg->mod_params->int_clear; > + rtlpci->int_clear =3D rtlpriv->cfg->mod_params->int_clear; > + rtlpriv->cfg->mod_params->sw_crypto =3D > + rtlpriv->cfg->mod_params->sw_crypto; > + rtlpriv->cfg->mod_params->disable_watchdog =3D > + rtlpriv->cfg->mod_params->disable_watchdog; [...] This is self-assignment. =C2=A0How is that going to help? Ben. --=20 Ben Hutchings Life is what happens to you while you're busy making other plans. - John Lenno= n --=-OdPGCVLdZvYpLHg06H00 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVsNubOe/yOyVhhEJAQr+Ew/7BZpATFUTjZ7Wk2AVDtkJDSnMZRjh/5rw gg4ArwO0f/1bGo+GWgdnVACEzU4zJwpCBBFkJCPfkjNcv8VjhR08eCnwP4icNErU sgPe60R9VZBejG+4S66FmAdFoi3ziG6Oa08Pihv/OcHlAMqlKW5M8UCZmvQ2XPor 9/IgB4pFE8KIOZab7cFEeJlZJYjSNvkDlJBV4iS05g42k1vKuJdo2cPVIhrhu30N XAn5Decv2Eg5Q2xOglg55Fz+ynGKjHNT969Albj/aTZ19F0SykocPOFT+dWBIFl/ B3niMDHdRxOc/GJNvO+J5hQNT46QR2QcV26L9chiBEm9q5IwVJzGihLREZL4ygS6 zPiGRcywrsUw0JD62nJX0/9U6H3qwwfG3pZnGJmt0wwb+Jz5JpYlqM69LOCpekns pWTH0lcNTrCvi00uvwT/yPEOzm7sRq3LfvpyCEEvExba+WL7RxoDaBiO5jx8l8sN UBpFpN7EmCJIql6GCMDbS5VH6Z/hTjKhLxtljI3VzxEXLIwF8CkfZsic/n4PVcUc 1cBt+6wneP6uZdfLGz7NUPbH7CyuKiIRGk1szAxeejKozt2LwtEj2HSDJ1MQY4C7 x3jIGx7D02EZOJejt7G1w2Pz6AQRGNQFqYxuhY6ek8jWTSY6RYmZIq6QcgQtrnZd K5tRRHo202c= =fxN8 -----END PGP SIGNATURE----- --=-OdPGCVLdZvYpLHg06H00--