From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755973AbcBPUDh (ORCPT ); Tue, 16 Feb 2016 15:03:37 -0500 Received: from lists.s-osg.org ([54.187.51.154]:48585 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754778AbcBPUDf (ORCPT ); Tue, 16 Feb 2016 15:03:35 -0500 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Benoit Parrot , Javier Martinez Canillas , Sakari Ailus , Mauro Carvalho Chehab , Bryan Wu , Laurent Pinchart , linux-media@vger.kernel.org Subject: [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented Date: Tue, 16 Feb 2016 17:03:21 -0300 Message-Id: <1455653001-10043-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After sub-dev registration in v4l2_async_test_notify(), the v4l2-async core calls the registered_async callback but if a sub-dev driver does not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which should not be considered an error. Reported-by: Benoit Parrot Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Check the return of v4l2_subdev_call (Benoit). drivers/media/v4l2-core/v4l2-async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index 716bfd47daab..a4b224d92572 100644 --- a/drivers/media/v4l2-core/v4l2-async.c +++ b/drivers/media/v4l2-core/v4l2-async.c @@ -120,7 +120,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier, } ret = v4l2_subdev_call(sd, core, registered_async); - if (ret < 0) { + if (ret < 0 && ret != -ENOIOCTLCMD) { if (notifier->unbind) notifier->unbind(notifier, sd, asd); return ret; -- 2.5.0