From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425180AbcBRIIU (ORCPT ); Thu, 18 Feb 2016 03:08:20 -0500 Received: from faui40.informatik.uni-erlangen.de ([131.188.34.40]:58253 "EHLO faui40.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424643AbcBRIHi (ORCPT ); Thu, 18 Feb 2016 03:07:38 -0500 From: Valentin Rothberg To: ldewangan@nvidia.com Cc: kbuild-all@01.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com, k.kozlowski@samsung.com, cw00.choi@samsung.com, a.zummo@towertech.it, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, kbuild test robot , Valentin Rothberg Subject: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings Date: Thu, 18 Feb 2016 09:06:56 +0100 Message-Id: <1455782816-5814-1-git-send-email-valentin.rothberg@posteo.net> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Laxman Dewangan Signed-off-by: Fengguang Wu Signed-off-by: Valentin Rothberg --- drivers/rtc/rtc-max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 5e924f3cde90..027ee7ebfff4 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -742,8 +742,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) goto err_rtc; } - ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0, - "rtc-alarm1", info); + ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, + IRQF_ONESHOT, "rtc-alarm1", info); if (ret < 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); -- 2.5.0