mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Tilman Schmidt <tilman@imap.cc>, netdev@vger.kernel.org
Cc: "Dmitry Vyukov" <dvyukov@google.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Martin Wilck" <Martin.Wilck@ts.fujitsu.com>,
	"Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	gigaset307x-common@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour
Date: Thu, 18 Feb 2016 23:14:59 +0100	[thread overview]
Message-ID: <1455833699.2379.19.camel@tiscali.nl> (raw)
In-Reply-To: <56C63AB7.9060401@imap.cc>

On do, 2016-02-18 at 22:42 +0100, Tilman Schmidt wrote:
> Acked-by: Tilman Schmidt <tilman@imap.cc>
> 
> Thanks for cleaning up the mess I left behind.

That's not how I look at it.

Commit 4c5e354a9742 ("ser_gigaset: fix deallocation of platform device
structure") provided a plausible fix for the issue we were trying to fix
two months ago. If the platform code hadn't been broken when you wrote
it - broken for ser_gigaset's corner case, that is - you would have
noticed the lifetime rules of driver_data the hard way. (I suspect I
might have never noticed if syzkaller hadn't insisted in rubbing my nose
in it.)

So chances are you would have come up with something similar to this fix
would commit 25cad69f21f5 ("base/platform: Fix platform drivers with no
probe callback") already have landed.

Thanks,


Paul Bolle

  reply	other threads:[~2016-02-18 22:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 20:29 [PATCH 0/1] " Paul Bolle
2016-02-18 20:29 ` [PATCH 1/1] " Paul Bolle
2016-02-18 21:42   ` Tilman Schmidt
2016-02-18 22:14     ` Paul Bolle [this message]
2016-02-18 23:46   ` Greg KH
2016-02-18 23:53     ` Paul Bolle
2016-02-19 20:56   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455833699.2379.19.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=Martin.Wilck@ts.fujitsu.com \
    --cc=dvyukov@google.com \
    --cc=gigaset307x-common@lists.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tilman@imap.cc \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®