From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752342AbdI1HxK (ORCPT ); Thu, 28 Sep 2017 03:53:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbdI1HxI (ORCPT ); Thu, 28 Sep 2017 03:53:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2906C9818E Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jasowang@redhat.com Subject: Re: [PATCH net-next RFC 5/5] vhost_net: basic tx virtqueue batched processing To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1506067355-5771-1-git-send-email-jasowang@redhat.com> <1506067355-5771-6-git-send-email-jasowang@redhat.com> <20170926222223-mutt-send-email-mst@kernel.org> <16ea7512-d770-21ef-edb6-3ada51f08592@redhat.com> <20170928011724-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: <1455d9db-3f2f-4139-8729-29fb03dd73aa@redhat.com> Date: Thu, 28 Sep 2017 15:52:59 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928011724-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 28 Sep 2017 07:53:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年09月28日 06:19, Michael S. Tsirkin wrote: > >>> 2. add new APIs and move the loop into vhost core >>> for more speedups >> I don't see any advantages, looks like just need some e.g callbacks in this >> case. >> >> Thanks > IUC callbacks pretty much destroy the code cache locality advantages, > IP is jumping around too much. I may miss something, but we need net specific code anyway in this case? Thanks