From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759883AbcBUACg (ORCPT ); Sat, 20 Feb 2016 19:02:36 -0500 Received: from smtprelay0132.hostedemail.com ([216.40.44.132]:43676 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759824AbcBUACf (ORCPT ); Sat, 20 Feb 2016 19:02:35 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 20,1.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2328:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3871:3872:4321:5007:6261:10004:10400:10848:11026:11658:11783:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: lunch44_8a8bb3f82de2c X-Filterd-Recvd-Size: 1537 Message-ID: <1456012950.4031.17.camel@perches.com> Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters From: Joe Perches To: Simon Quigley , clm@fb.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 20 Feb 2016 16:02:30 -0800 In-Reply-To: <1455992258-9176-1-git-send-email-tsimonq2@ubuntu.com> References: <1455992258-9176-1-git-send-email-tsimonq2@ubuntu.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote: > checkpatch.pl reported a warning of over 80 characters on line 1833 [] > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c [] > @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root, >   unsigned long ptr; >   >   while (1) { > - ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref, > + ret = btrfs_find_one_extref(fs_root, > + inum, > + offset, > + path, > + &extref, >       &offset); I think this is poor because all the arguments aren't aligned. It'd be nicer like: ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref, &offset);