From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbcBUBtW (ORCPT ); Sat, 20 Feb 2016 20:49:22 -0500 Received: from smtprelay0181.hostedemail.com ([216.40.44.181]:37466 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751007AbcBUBtT (ORCPT ); Sat, 20 Feb 2016 20:49:19 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 20,1.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2328:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:5007:6248:7652:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12438:12517:12519:12555:12740:13069:13161:13229:13311:13357:13894:14659:21080:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: toad56_33fd60b32051b X-Filterd-Recvd-Size: 2003 Message-ID: <1456019356.4031.18.camel@perches.com> Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 From: Joe Perches To: Simon Quigley , clm@fb.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 20 Feb 2016 17:49:16 -0800 In-Reply-To: <56C90B73.7030702@ubuntu.com> References: <1455992258-9176-1-git-send-email-tsimonq2@ubuntu.com> <1456016178-4560-1-git-send-email-tsimonq2@ubuntu.com> <56C90B73.7030702@ubuntu.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote: > Better? No, not really. The alignment should be to the open parenthesis as I wrote in the first reply. > On 02/20/2016 06:56 PM, Simon Quigley wrote: > > checkpatch.pl reported a warning of over 80 characters on line 1833 > > > > Adjusted to put &extref and &offset on a different line > > > > Signed-off-by: Simon Quigley > > --- > >   fs/btrfs/backref.c | 4 ++-- > >   1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > > index f6dac40..956fffa 100644 > > --- a/fs/btrfs/backref.c > > +++ b/fs/btrfs/backref.c > > @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, > > struct btrfs_root *fs_root, > >    unsigned long ptr; > > > >    while (1) { > > - ret = btrfs_find_one_extref(fs_root, inum, offset, > > path, &extref, > > -     &offset); > > + ret = btrfs_find_one_extref(fs_root, inum, offset, > > path, > > + &extref, > > &offset); > >    if (ret < 0) > >    break; > >    if (ret) { > >