From: Markus Pargmann <mpa@pengutronix.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, nbd-general@lists.sourceforge.net,
kernel@pengutronix.de, Markus Pargmann <mpa@pengutronix.de>
Subject: [PATCH 3/7] nbd: Timeouts are not user requested disconnects
Date: Sun, 21 Feb 2016 15:01:23 +0100 [thread overview]
Message-ID: <1456063287-28941-4-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1456063287-28941-1-git-send-email-mpa@pengutronix.de>
It may be useful to know in the client that a connection timed out. The
current code returns success for a timeout.
This patch reports the error code -ETIMEDOUT for a timeout.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/block/nbd.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 438f4dc549db..2e14e51b5ea3 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -57,6 +57,7 @@ struct nbd_device {
int blksize;
loff_t bytesize;
int xmit_timeout;
+ bool timedout;
bool disconnect; /* a disconnect has been requested by user */
struct timer_list timeout_timer;
@@ -154,10 +155,9 @@ static void nbd_xmit_timeout(unsigned long arg)
if (list_empty(&nbd->queue_head))
return;
- nbd->disconnect = true;
-
spin_lock_irqsave(&nbd->sock_lock, flags);
+ nbd->timedout = true;
if (nbd->sock)
kernel_sock_shutdown(nbd->sock, SHUT_RDWR);
@@ -754,7 +754,10 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
if (max_part > 0)
blkdev_reread_part(bdev);
if (nbd->disconnect) /* user requested, ignore socket errors */
- return 0;
+ error = 0;
+ if (nbd->timedout)
+ error = -ETIMEDOUT;
+
return error;
}
--
2.7.0
next prev parent reply other threads:[~2016-02-21 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 14:01 [PULL] NBD for 4.6 Markus Pargmann
2016-02-21 14:01 ` [PATCH 1/7] nbd: Fix debugfs error handling Markus Pargmann
2016-02-21 14:01 ` [PATCH 2/7] nbd: Remove signal usage Markus Pargmann
2016-02-21 14:01 ` Markus Pargmann [this message]
2016-02-21 14:01 ` [PATCH 4/7] nbd: Cleanup reset of nbd and bdev after a disconnect Markus Pargmann
2016-02-21 14:01 ` [PATCH 5/7] nbd: Move flag parsing to a function Markus Pargmann
2016-02-21 14:01 ` [PATCH 6/7] nbd: ratelimit error msgs after socket close Markus Pargmann
2016-02-21 14:01 ` [PATCH 7/7] nbd: Create size change events for userspace Markus Pargmann
2016-03-03 7:48 ` [PULL] NBD for 4.6 Markus Pargmann
2016-03-03 13:53 ` Jens Axboe
2016-03-03 15:04 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456063287-28941-4-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=axboe@kernel.dk \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®