From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753093AbcBURau (ORCPT ); Sun, 21 Feb 2016 12:30:50 -0500 Received: from sauhun.de ([89.238.76.85]:53469 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbcBURaq (ORCPT ); Sun, 21 Feb 2016 12:30:46 -0500 From: Wolfram Sang To: platform-driver-x86@vger.kernel.org Cc: Wolfram Sang , Alex Hung , Darren Hart , linux-kernel@vger.kernel.org Subject: [PATCH] intel-hid: allocate correct amount of memory for private struct Date: Sun, 21 Feb 2016 15:22:27 +0100 Message-Id: <1456064574-11245-1-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 2.7.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We want the size of the struct, not of a pointer to it. To be future proof, just dereference the pointer to get the desired type. Signed-off-by: Wolfram Sang --- Compile tested only. Found by static code analysis. drivers/platform/x86/intel-hid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c index e20f23e04c24ce..f93abc8c1424ad 100644 --- a/drivers/platform/x86/intel-hid.c +++ b/drivers/platform/x86/intel-hid.c @@ -180,8 +180,7 @@ static int intel_hid_probe(struct platform_device *device) return -ENODEV; } - priv = devm_kzalloc(&device->dev, - sizeof(struct intel_hid_priv *), GFP_KERNEL); + priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; dev_set_drvdata(&device->dev, priv); -- 2.7.0