From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbcBVJ1z (ORCPT ); Mon, 22 Feb 2016 04:27:55 -0500 Received: from mail-bn1bon0092.outbound.protection.outlook.com ([157.56.111.92]:37568 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751130AbcBVJ1t (ORCPT ); Mon, 22 Feb 2016 04:27:49 -0500 X-Greylist: delayed 1318 seconds by postgrey-1.27 at vger.kernel.org; Mon, 22 Feb 2016 04:27:49 EST Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=analog.com; From: To: , CC: , Michael Hennerich Subject: [PATCH] drivers/misc/ad525x_dpot: AD5274 fix RDAC read back errors Date: Mon, 22 Feb 2016 10:20:24 +0100 Message-ID: <1456132824-28591-1-git-send-email-michael.hennerich@analog.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD053;1:nzJCIkf/ssq35SLueccB17TjpB2VpdbU7fzBjykKBDXQH8/kO9h4pcR6+t7txMTSwdm4PwMGJuQgNxNLZ13LQgVAvMyKyYb5DPJAGumX5pnYuBRnKnhagPeTZ9LamREcGz6qdI+xTNGCy+J8xFHVxuai4Xyn4Q5ZgHdt5I49VZW0nLktoR10jRF/hOG3GE4r3pTmiKh0m5zLe1xAES9mUJRz5q8bX5JckRC58Y7dqpowPqXknwtVfmSj251URQP1VjNYMZAQf63b7mxAUmXh2/KZAE+WWeTc1XDq2l3CQVlvEIT61Mg9ZByzjxiJMeRx+YnOcVzMqCzETOla35ZOXPfxPpkRS46Q4OnFzsXz0cKCJ+ENhRIoLvJEleZB439ZmTD0n71s+5RRJQkK9iOvvOXufpSpAQogYh7W2H67axBGOsC+EMRhh0ImqJmmbWME2ttZkuPLtXtiqjutYZrlhQ== X-Forefront-Antispam-Report: CIP:137.71.25.57;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(5001770100001)(33646002)(107886002)(5001970100001)(50986999)(77096005)(86362001)(36756003)(50466002)(229853001)(106466001)(50226001)(87936001)(2906002)(2876002)(4326007)(5003600100002)(92566002)(5008740100001)(11100500001)(6806005)(586003)(48376002)(1096002)(1220700001)(47776003)(4001430100002)(189998001)(19580405001)(86152002)(19580395003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR0301MB0753;H:nwd2mta2.analog.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: eca90c5e-1d9d-4595-fc5e-08d33b6a6d5a X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0753;2:fWOjBInaPlhcW9wgJG28aqudFtVEL1Fn1/0Zqm5mMYTVSrhInIPhgTXoiEbe3sD+NPxzpoCOLSUbKGmLh5scKC90lKmGvGTTnZ8B6+GwDBCSyv9ivy01jmxObQegA46mptfB/NSB/huYwJcrtzmRLO+he55ds+t84gbBb/dmRLjIzqUUyui7zrMDhPJtuDjo;3:18ejUXnD/orgPjSn291fkn6eJjC1ozl2CAsEwdw5Xe3PJabc5Hy7R2waeYX5IAreIM3NND9wC3BcOVe4DAaTa1SwFhEcUoCwrJWXER6k+e0zNSTM6VtqVFHFWlceZl/+i8+cJsSbFYLKwbclV7PlsUAnfPquIEFXYBkOfOyrdq0JGjH6MxWBIr1C+QsFoF2sGwB5hU0uqC/BMOpLaZYhuVui60973BBJQmjfa/69DH0+nL0gwtfaMLrbMv2ffLi45ZVSBn9RRzlIf1kweD+Xrw==;25:Phd8atItzThNl2rom5b+fv2Zj2y8aG6/NC2LBBzreuYKlXMrbeKnTquuPzFM1YgKAFu91jXB2OsXXlf9XY1l4NG7vzd7lWBbL/NelNlVs3kJePQyM6M6APFLX7VD4mRerkhQEtkb4hfE/tcnZO6tjFjSJN7moNVYR82po6k3j7dyg7d7xPD3IrhvQf0sCa7LTPXCPzScUTXfK+eoj69LoUwrimOooPyqnnHF2t2VgFeKd6a0WfP2j4hq4h2KTzKyE395zCwEs7CaGwPeM7OCxSliPubZmHzhCFG6mVUdwU5d3bxMwo4Zpy5KVL3BWnsIGZtUbPyHor3TYnfZ1D80FgSrrH3KNmlZ4jyi6nlp4rw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BN1PR0301MB0753; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0753;20:AlOXHU+wBly2JSRxX2/QyaZVKz8HKAbJTOnbU8tRpBJI9igzqUSI80GFPZcV04Bj9PNzBNJyV4rS1fhkOWkOygMYoi0uxNGjoCAQyDwHyvp2c94lZQLcy1k5fP3tK+DWdr9rjF4AXSVtkUG+DmofGHiA1vFmtbLBY5w/kuaRZovI3S8xQAI85E8H6qzXwgVg31f/r8DMpD5LYybnBB7lTv0Jo13ngB4daU7Y2oU6Z4M/Pjaww1YRE/aQ7SoZH5UUS58MCMGFYaSY2xD2vpRdRt6Xl9b27/BDRILQ9+zUCYIJH3p5dAJPe8YAGq+2kg5DfRKWqxKRKbl0/xx0zZwuYpRotOpRBkI/U7Mu17/kSwh00TkOJ+/qrRQOFPHxvTENutbWZE/meOIuYUABQUlxvMFXEAbEbRQzE8khOfkL/Aq9EEWCrtt6LxHEm5E7Fw9eDF8XrhEMTmpiGTEQ2ZsnaFu3OsCldRpOVvz/cOxo5S8LRHNp/WdnutyxV8Tuiea8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(8121501046)(5005006)(13018025)(13024025)(13023025)(13015025)(10201501046)(3002001);SRVR:BN1PR0301MB0753;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0753; X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0753;4:j6ozh7LJw6p3SgqK6UwC6KjcnPnrpM5rNa5NC1w7GlZz2cKHsLZO4BHKfZsNXA4QrJpFhDvFM7J5uqx5kQOZS80+GiMwv14Jvhn6Z3w4om+IBfQICZFsOOqCizmjjf/i7os0Tg3Vl9c+cs2/Rtcx5t4BxE+vicsNSOx13WALBejwFmscDj2op4biP+DWocSOF/mSq/6kmpL4CTNPyLmz7Ho5nt3q/Q9GmFHrQytqnIqjloJomuublqK2n0xIDQmiH/Cqwb1hqitVmePbsLaUgNvS9c7W9QlDAF+bCwmyl0UZUCv4CSscFnX4yIVQCz+O/8aEKNgwjK1s+2ZiVE1phtS0eBsr2xE4eJczCf/eZ0zSF/04RONShEOOwe+WFHQ6t7SFwdQ2yn1/iZPc7NYTxjD1+ApX5h94nitpd3eA8p56oxz1Sh4Le4khg3+ZQ+vbY7r/LdN3xm2sJjjN1XKhn3CRj6kN0Z742PIhQt6qgP1xjkqheb1/AycCxtaXg02/ X-Forefront-PRVS: 0860FE717F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR0301MB0753;23:mf19JJPlBkMr5vL+1FPJYYclq8H8eCt7yT17jEr?= =?us-ascii?Q?0rD5MQQWe6tU2waZpWzLVXmYKorqxsw5I40OjirYS1NhbuXH41UyxP7qh/dY?= =?us-ascii?Q?zERO+pSIIpfvgOkGuOw2hAWdgs/JB9yRd4uc93zm5kGKL7CZ2aj69jKvLdX9?= =?us-ascii?Q?kRufgLTgyCyIYdwTRfl8j5VXHJ+HpJ+VobcX1zgaUkBXeutUyfEw0LSwYLOR?= =?us-ascii?Q?enyVO057llGe+ANwnRQ5Vw9zLuCo56Mq49/xboFo+iyytGqk19a+4LuzR6pp?= =?us-ascii?Q?e0cnEY8OqLG+H7MQCab0fyDl36I0VIEiB14pT2TJdLUqWVHwsBoPatB9xseS?= =?us-ascii?Q?Vx8ijEU0gwgRnYOtRJHI0i4v8pKawChcDVWMyAQ84SmjhYFlO/YUJtX0DFVV?= =?us-ascii?Q?YU/qWycVPP3kCBW1AdeBbfWtgxnFI2fW8+C3hkkMtyqtfiREpyir+y5nC/Eq?= =?us-ascii?Q?WdGEqXIc9syJKgtMy6ADQy1JyLXTTYyH908Ib9wXLLebd6bB0qRgfwLd6oF9?= =?us-ascii?Q?8RKA3s/xbtYY2NVQ1tJPIR9WJXP+LDXgQX1nvnEu8KHyMw6JGjgkrPPzVJaS?= =?us-ascii?Q?Kd7P8lhm/drLIxxLK3B/C6fdGxp/IPbrdVrWYKfVd6eA9U5m30GbKFJ8bVHu?= =?us-ascii?Q?kqesDIHf+LeHKyBHN6TI3K69N2xSPwejGq+BS8qSUF6eHWjgjzYpb7kMHBcG?= =?us-ascii?Q?Viugf3B1dAy5yASDu8yDIV7vGOH1yCx7Dcdt1Hji4SFchWD5fTEMrV0ukb9x?= =?us-ascii?Q?ags9j7hR9CNg6oA14X7EAonyGTLmKJycS/2/Adj3YV7owGUbg+8vbI4e68ha?= =?us-ascii?Q?ZST+Qhf9ipdmGlPkxIawMEtHvTzDpcfBtsKsd084p0fuUPT/Zl8eHsU2oET4?= =?us-ascii?Q?J7EN1nvdfRIRaAonLR1cWf/+KzHa7+5JdNEfs0fjDFNE/nKEt1NjH6LrjZ9N?= =?us-ascii?Q?tiOE1SHDX9jaT4/nEPjE/TKhkZLRqxetpWIDwexjEu/M1s/o+vut1I51YEgN?= =?us-ascii?Q?zBtE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR0301MB0753;5:sKgLqdotqxt2uF/MfPp3cT+Ro8lFuHKiDH+1WUqKAY+pFEP8HMZoGa+wTxvnk5dOSbHa4KnFPKKVuGO/RFUJq0Yyh/MzHEvhTTfRpJuMGVCbHoS3d6TWYOdaLmvZ8XU/R1nowZuhk7P7N20+z88Tcg==;24:EKs4VglUMOtEb7PpwKbJDnXHGpFn7YFwiccUUU67Rrr7o335hszizUhKdNaYvkEf+lpoyJ2NlxtgT5NN8DRMS9jaTbJ30vTGhGjQQFqhMlg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2016 09:27:47.3659 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta2.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Hennerich Fix RDAC read back errors caused by a typo. Value must shift by 2. Fixes: a4bd394956f2 ("drivers/misc/ad525x_dpot.c: new features") Signed-off-by: Michael Hennerich --- drivers/misc/ad525x_dpot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index e9bbc7b..51e3ec2 100644 --- a/drivers/misc/ad525x_dpot.c +++ b/drivers/misc/ad525x_dpot.c @@ -216,7 +216,7 @@ static s32 dpot_read_i2c(struct dpot_data *dpot, u8 reg) */ value = swab16(value); - if (dpot->uid == DPOT_UID(AD5271_ID)) + if (dpot->uid == DPOT_UID(AD5274_ID)) value = value >> 2; return value; default: -- 1.9.1