From: Kieran Bingham <kieran.bingham@linaro.org>
To: jan.kiszka@siemens.com, linux-kernel@vger.kernel.org
Cc: lee.jones@linaro.org, peter.griffin@linaro.org,
maxime.coquelin@st.com,
Kieran Bingham <kieran.bingham@linaro.org>
Subject: [PATCH 5/8] scripts/gdb: Support !CONFIG_MODULES gracefully
Date: Mon, 22 Feb 2016 15:24:09 +0000 [thread overview]
Message-ID: <1456154652-29023-6-git-send-email-kieran.bingham@linaro.org> (raw)
In-Reply-To: <1456154652-29023-1-git-send-email-kieran.bingham@linaro.org>
If CONFIG_MODULES is not enabled, lx-lsmod tries to find
a non-existent symbol and generates an unfriendly traceback:
(gdb) lx-lsmod
Address Module Size Used by
Traceback (most recent call last):
File "scripts/gdb/linux/modules.py", line 75, in invoke
for module in module_list():
File "scripts/gdb/linux/modules.py", line 24, in module_list
module_ptr_type = module_type.get_type().pointer()
File "scripts/gdb/linux/utils.py", line 28, in get_type
self._type = gdb.lookup_type(self._name)
gdb.error: No struct type named module.
Error occurred in Python command: No struct type named module.
Catch the error and return an empty module_list() for a clean command
output as follows:
(gdb) lx-lsmod
Address Module Size Used by
(gdb)
Signed-off-by: Kieran Bingham <kieran.bingham@linaro.org>
---
scripts/gdb/linux/modules.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/gdb/linux/modules.py b/scripts/gdb/linux/modules.py
index 571489b3b9c2..60224d8bbfb2 100644
--- a/scripts/gdb/linux/modules.py
+++ b/scripts/gdb/linux/modules.py
@@ -21,8 +21,11 @@ module_type = utils.CachedType("struct module")
def module_list():
global module_type
+ modules = utils.gdb_eval_or_none("modules")
+ if modules is None:
+ return
+
module_ptr_type = module_type.get_type().pointer()
- modules = gdb.parse_and_eval("modules")
for module in lists.list_for_each_entry(modules, module_ptr_type, "list"):
yield module
--
2.5.0
next prev parent reply other threads:[~2016-02-22 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 15:24 [PATCHv2 0/8] gdb/scripts: Linux awareness debug commands Kieran Bingham
2016-02-22 15:24 ` [PATCH 1/8] scripts/gdb: Provide linux constants Kieran Bingham
2016-02-22 15:24 ` [PATCH 2/8] scripts/gdb: Provide a kernel list item generators Kieran Bingham
2016-02-22 15:24 ` [PATCH 3/8] scripts/gdb: Convert modules usage to lists functions Kieran Bingham
2016-02-22 15:24 ` [PATCH 4/8] scripts/gdb: Provide exception catching parser Kieran Bingham
2016-02-22 15:24 ` Kieran Bingham [this message]
2016-02-22 15:24 ` [PATCH 6/8] scripts/gdb: Add io resource readers Kieran Bingham
2016-02-22 15:24 ` [PATCH 7/8] scripts/gdb: Add mount point list command Kieran Bingham
2016-02-22 15:24 ` [PATCH 8/8] scripts/gdb: Add meminfo command Kieran Bingham
2016-02-24 9:44 ` Kieran Bingham
2016-02-29 16:36 ` [PATCHv2 0/8] gdb/scripts: Linux awareness debug commands Jan Kiszka
2016-02-29 17:01 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456154652-29023-6-git-send-email-kieran.bingham@linaro.org \
--to=kieran.bingham@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®