From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: konrad.wilk@oracle.com, david.vrabel@citrix.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
mcgrof@kernel.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: [PATCH] xen/x86: Zero out .bss for PV guests
Date: Mon, 22 Feb 2016 17:06:07 -0500 [thread overview]
Message-ID: <1456178767-8038-1-git-send-email-boris.ostrovsky@oracle.com> (raw)
Baremetal kernels clear .bss early in the boot. Since Xen PV guests don't
excecute that early code they should do it too.
(Since we introduce macros for specifying 32- and 64-bit registers we
can get rid of ifdefs in startup_xen())
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
arch/x86/xen/xen-head.S | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index b65f59a..2af87d1 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -35,16 +35,31 @@
#define PVH_FEATURES (0)
#endif
- __INIT
-ENTRY(startup_xen)
- cld
#ifdef CONFIG_X86_32
- mov %esi,xen_start_info
- mov $init_thread_union+THREAD_SIZE,%esp
+#define REG(register) %e##register
+#define WSIZE_SHIFT 2
+#define STOS stosl
#else
- mov %rsi,xen_start_info
- mov $init_thread_union+THREAD_SIZE,%rsp
+#define REG(register) %r##register
+#define WSIZE_SHIFT 3
+#define STOS stosq
#endif
+
+ __INIT
+ENTRY(startup_xen)
+ cld
+
+ /* Clear .bss */
+ xor REG(ax),REG(ax)
+ mov $__bss_start,REG(di)
+ mov $__bss_stop,REG(cx)
+ sub REG(di),REG(cx)
+ shr $WSIZE_SHIFT,REG(cx)
+ rep STOS
+
+ mov REG(si),xen_start_info
+ mov $init_thread_union+THREAD_SIZE,REG(sp)
+
jmp xen_start_kernel
__FINIT
--
2.1.0
next reply other threads:[~2016-02-22 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 22:06 Boris Ostrovsky [this message]
2016-02-24 14:12 ` [Xen-devel] " David Vrabel
2016-02-24 14:15 ` Andrew Cooper
2016-02-24 14:52 ` Boris Ostrovsky
2016-02-24 14:58 ` David Vrabel
2016-02-24 16:22 ` Luis R. Rodriguez
2016-02-24 16:46 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456178767-8038-1-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®