From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757364AbcBWGqn (ORCPT ); Tue, 23 Feb 2016 01:46:43 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:60620 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757303AbcBWGql (ORCPT ); Tue, 23 Feb 2016 01:46:41 -0500 X-AuditID: cbfec7f5-f79b16d000005389-dd-56cc004e84c9 From: Andrzej Hajda To: Liam Girdwood , Mark Brown Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , anish kumar , Axel Lin , alsa-devel@alsa-project.org (moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] ASoC: max9867: fix type of variable containing error codes Date: Tue, 23 Feb 2016 07:45:14 +0100 Message-id: <1456209914-13375-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e/4FV0/hjNhBo0vlSxurTvHanHl4iEm iyNzvjJbbJyxntVi6sMnbBbfrnQwWVzeNYfNYu2Ru+wW8/ZtZnPg9NjwuYnNY+esu+webT/L PDat6mTz6NuyitHj8ya5ALYoLpuU1JzMstQifbsEroydh2awFPSwV/zbI97A+I+1i5GTQ0LA RGLC16WMELaYxIV769m6GLk4hASWMkpM2XyEEcJpYpJ4eOA1G0gVm4CmxN/NN8FsEQEPidbt G5hBbGaB50wSpyalgtjCAv4Sq55/BpvKIqAq8XDbMbAaXgFniV0PJjBDbJOTOHlsMusERu4F jAyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUIC6OsOxqXHrA4xCnAwKvHwenidDhNiTSwr rsw9xCjBwawkwrvmDFCINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1KzU1MLUotg skwcnFINjLv1OwWnJae65Nq6nDtldyvov+9t0WlFIj0rdWJipqsvm/nseqr/VNEpYXZ88RN3 XfgqUFT6/LcYm+OJd3uv2x+fdzbYIlLHZ9/Sz46Lbhz9PdekYs5OqQcKOi0G1advMPyoa46S t5yx6WdD3oonHKfZV21rbKxRL5ghWd7gtP/ltLQVW9/87FViKc5INNRiLipOBABny16xHAIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org value variable can contain error values and is compared with zero. Its type must be signed. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda --- sound/soc/codecs/max9867.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index ab7a94d..4fb6fc7 100755 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -180,7 +180,8 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, { struct snd_soc_codec *codec = dai->codec; struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec); - unsigned int ni_h, ni_l, value; + unsigned int ni_h, ni_l; + int value; value = get_ni_value(max9867->sysclk, params_rate(params)); if (value < 0) -- 1.9.1