From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 02/14] documentation: Fix control dependency and identical stores
Date: Tue, 23 Feb 2016 21:00:35 -0800 [thread overview]
Message-ID: <1456290047-16654-2-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160224050021.GA14616@linux.vnet.ibm.com>
The summary of the "CONTROL DEPENDENCIES" section incorrectly states that
barrier() may be used to prevent compiler reordering when more than one
leg of the control-dependent "if" statement start with identical stores.
This is incorrect at high optimization levels. This commit therefore
updates the summary to match the detailed description.
Reported by: Jianyu Zhan <nasa4836@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
Documentation/memory-barriers.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index 904ee42d078e..e26058d3e253 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -800,9 +800,13 @@ In summary:
use smp_rmb(), smp_wmb(), or, in the case of prior stores and
later loads, smp_mb().
- (*) If both legs of the "if" statement begin with identical stores
- to the same variable, a barrier() statement is required at the
- beginning of each leg of the "if" statement.
+ (*) If both legs of the "if" statement begin with identical stores to
+ the same variable, then those stores must be ordered, either by
+ preceding both of them with smp_mb() or by using smp_store_release()
+ to carry out the stores. Please note that it is -not- sufficient
+ to use barrier() at beginning of each leg of the "if" statement,
+ as optimizing compilers do not necessarily respect barrier()
+ in this case.
(*) Control dependencies require at least one run-time conditional
between the prior load and the subsequent store, and this
--
2.5.2
next prev parent reply other threads:[~2016-02-24 5:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 5:00 [PATCH tip/core/rcu 0/14] Documentation updates for 4.6 Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 01/14] documentation: Add real-time requirements from CPU-bound workloads Paul E. McKenney
2016-02-24 5:00 ` Paul E. McKenney [this message]
2016-02-24 21:12 ` [PATCH tip/core/rcu 02/14] documentation: Fix control dependency and identical stores Mathieu Desnoyers
2016-02-24 21:40 ` Paul E. McKenney
2016-02-25 6:41 ` Jianyu Zhan
2016-02-25 14:08 ` Paul E. McKenney
2016-02-25 8:21 ` Peter Zijlstra
2016-02-25 14:07 ` Paul E. McKenney
2016-02-25 14:48 ` Peter Zijlstra
2016-02-25 15:42 ` Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 03/14] documentation: Fix memory-barriers.txt section references Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 04/14] documentation: Add synchronize_rcu_mult() to the requirements Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 05/14] documentation: Remove obsolete reference to RCU-protected indexes Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 06/14] documentation: Subsequent writes ordered by rcu_dereference() Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 07/14] documentation: Distinguish between local and global transitivity Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 08/14] documentation: Add alternative release-acquire outcome Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 09/14] documentation: Add documentation for RCU's major data structures Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 10/14] documentation: Explain why rcu_read_lock() needs no barrier() Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 11/14] documentation: Transitivity is not cumulativity Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 12/14] documentation: Document illegality of call_rcu() from offline CPUs Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 13/14] documentation: Explain how RCU's combining tree fights contention Paul E. McKenney
2016-02-24 5:00 ` [PATCH tip/core/rcu 14/14] documentation: Clarify compiler store-fusion example Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456290047-16654-2-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®