From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758170AbcBXIc3 (ORCPT ); Wed, 24 Feb 2016 03:32:29 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:17415 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbcBXIc1 (ORCPT ); Wed, 24 Feb 2016 03:32:27 -0500 X-AuditID: cbfec7f4-f79026d00000418a-a4-56cd6a98df17 From: Andrzej Hajda To: Alexander Aring , Jukka Rissanen , linux-wpan@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] 6lowpan: fix error checking code Date: Wed, 24 Feb 2016 09:32:13 +0100 Message-id: <1456302733-7053-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJJMWRmVeSWpSXmKPExsVy+t/xa7ozss6GGWzazWVxa905Vou5Z0st Ns5Yz2rx/NNWdos51/qYLS7vmsNmcWfyMhaLtUfusjtweMw7GejR/9fAo2/LKkaPz5vkAlii uGxSUnMyy1KL9O0SuDJ2zD/EVHCYreL6qZfMDYzbWLsYOTkkBEwkOra1skPYYhIX7q1nA7GF BJYySizZpNjFyAVkNzFJfPz9mAkkwSagKfF3802wIhGBcol1m04ygxQxC5xnlGg5dJkRJCEs YCixYPJ2MJtFQFXi5sGvYNt4BZwk/i/ZywyxTU7i5LHJrBMYuRcwMqxiFE0tTS4oTkrPNdQr TswtLs1L10vOz93ECAmQLzsYFx+zOsQowMGoxMP7YMOZMCHWxLLiytxDjBIczEoivHZpZ8OE eFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwBhqEujlnLDl 5ebCiO9uCZemP1KYvvvAnKLEBJbVBvusl16vO1T/e5XVB/kf213crc9WFrirbZ/F9P/G7DW2 Bfx3Gx9r/eRk7lGqftUw18yI+Xmq5L39Mu9+PpE94hc+NUDBpPHH9VNrdjBl2jvXfLhQ27rR OS73oofR1XdTHzFovHuSrc53aIcSS3FGoqEWc1FxIgDJX0BLDAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bool variable 'fail' is always non-negative, it indicates an error if it is true. The problem has been detected using coccinelle script scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci Signed-off-by: Andrzej Hajda --- net/6lowpan/iphc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/6lowpan/iphc.c b/net/6lowpan/iphc.c index d2a565c..0fe954f 100644 --- a/net/6lowpan/iphc.c +++ b/net/6lowpan/iphc.c @@ -482,7 +482,7 @@ static int lowpan_uncompress_multicast_ctx_daddr(struct sk_buff *skb, ipaddr->s6_addr[0] = 0xFF; fail = lowpan_fetch_skb(skb, &ipaddr->s6_addr[1], 2); fail |= lowpan_fetch_skb(skb, &ipaddr->s6_addr[12], 4); - if (fail < 0) + if (fail) return -EIO; /* take prefix_len and network prefix from the context */ -- 1.9.1